Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
4.94k stars 143 forks source link

Side Web Panel not Loading Icons Correctly. #1221

Open Mibix opened 2 weeks ago

Mibix commented 2 weeks ago

Pre-Submission Checklist

Bug Summary

Some sites don't load their icons properly and show up either blank or as just a globe in the side web panel. You can force them with custom CSS if you know the web address of the favicon.ico but its not easy to find. This is a lot less troublesome on Vivaldi. Homeassistant instances are one where it can't find it for example.

Reproduction Steps

  1. Add new web panel
  2. Add a site where the favicon.ico isn't in the root of the site.
  3. Watch the icon be missing

Expected Behavior

Should load the same icon that is displayed when the site is loaded in a tab.

Actual Behavior

Loads a default web icon or no icon at all

Screenshots

Screenshot 2024-06-12 033705

Browser Version

11.14.0 (64-bit)

Operating System

Win 11 Version 22H2 Build 22621.3737

Additional Context

No response

nyanrus commented 2 weeks ago

this issue is from https://www.reddit.com/r/Floorp/s/IpDy6Y3NOn This is because Floorp uses external "icon provider" to get favicon. the way to fix is to allow customizing to get favicon from server directly with IP(incl.ipv6) pattern.

Mibix commented 2 weeks ago

this issue is from https://www.reddit.com/r/Floorp/s/IpDy6Y3NOn This is because Floorp uses external "icon provider" to get favicon. the way to fix is to allow customizing to get favicon from server directly with IP(incl.ipv6) pattern.

Yeah I got the workaround working but what is the advantage of having an external icon provider?

nyanrus commented 2 weeks ago

It is useful to get icon without accessing to the server. Using external icon provider, Floorp do not need to get the html, no accessing to the server, no log to the server.

Some website seems to use svg with html link tag, not favicon.ico. And the external icon providers provide unified API to get these favicon. https://developers.google.com/search/docs/appearance/favicon-in-search

deletedpenguin commented 2 weeks ago

Ideally it parses the website for the icon, but an alternative would be to be able to set a custom icon for websites. This would also solve for those local links or those that want to customise the icons.