Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
5.73k stars 160 forks source link

[Bug]: Unable to disable Firefox's shortcuts and define custom shortcuts. #1250

Open littleapple-juice opened 3 months ago

littleapple-juice commented 3 months ago

Pre-Submission Checklist

Bug Summary

Cannot set custom shortcuts since disabling Firefox's shortcuts won't work and the option just reverts back to unchecked.

Reproduction Steps

  1. settings
  2. keyboard shortcuts
  3. check "disable Firefox shortcuts"
  4. restart

Expected Behavior

Can set custom shortcuts.

Actual Behavior

Disabling Firefox shortcuts is not working after restart.

Screenshots

image

Browser Version

11.14.1 (64-bit)

Operating System

Windows 10

Additional Context

I also downloaded portable version, but the issue persists.

melroy89 commented 2 months ago

Not sure if it's related, but I want the default shortcuts like ctrl+t for a new tab. Why is this not present by default?

NightRare commented 2 months ago

Having the same problem here on a brand new installed browser. It would be nice if this issue can get looked into, thanks.


Update: I just tested around and it seems 11.13.3 is the last version that doesn't have the problem. Potentially the TS & SolidJS rewrite had broken this shortcut feature.

yarub123 commented 2 months ago

Issue still exists... Downgrading to 11.13 is only a temp fix... though if you have auto-update on it doesn't last long 🙃. I think @NightRare is correct, it is the TS & SolidJS rewrite.

CutterKnife commented 2 months ago

I am told that they are trying to fix this problem when they release Floorp 11, which is based on ESR128.

yarub123 commented 1 month ago

@CutterKnife Appreciate the update. Thank you brother.

uniresuto commented 1 month ago

Same issue on 11.17.7. I'm on Linux, Fedora 40, Flatpak version of the browser.

brtholomy commented 2 weeks ago

same on 11.18.1. Arch Linux, via AUR

vic047 commented 2 weeks ago

same on 11.18.1 with Win10