Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
5.73k stars 160 forks source link

[Bug]: split view will result in other web pages invisible #1355

Closed lonnyshoal closed 1 month ago

lonnyshoal commented 1 month ago

Pre-Submission Checklist

Bug Summary

After creating split view and switching to another existing non-split-view tab, the page of that tab is invisible.

Reproduction Steps

  1. Creating a split view by open in split view.
  2. Switching to another existing non-split-view tab.
  3. The web page of that tab is invisible.

Expected Behavior

All web pages of other existing tabs should be still visible.

Actual Behavior

If you go to the split view tab and then go to another tab, the web page of another tab will be invisible.

Screenshots

another page invisible after split view

Browser Version

11.17.3

Operating System

ubuntu 24.04

Additional Context

the workaround is switching to another application program and switching back to the browser

surapunoyousei commented 1 month ago

duplicate

lonnyshoal commented 1 month ago

I cannot find any open issue ticket with the same issue. I tested the new 11.17.4 version and confirmed this issue has not been fixed.

guigirl42 commented 1 month ago

It IS still a bad problem in my ArchLinux 11.17.4. I do not understand why this ticket was closed :exploding_head:

winstonma commented 1 month ago

I recently use 11.17.5 (on both linux and windows) and I got this issue too. Here is my test case

  1. Open 3 Tab with different content (e.g. Tab1: bbc.co.uk/ Tab2: cnn.com/Tab3: espn.com)
  2. Combine Tab1 and Tab2 using split view
  3. Go to the Tab3, it would show nothing

By the way I am running Floorp in Ubuntu Linux 22.04

@surapunoyousei could you please take a look

winstonma commented 1 month ago

@guigirl42 I updated Floorp to 11.17.7 and it seems the problem is fixed.

Please check that too

guigirl42 commented 1 month ago

Thanks, but no, i'm still getting dead tabs after invoking the split view function via kb shortcut. :sob:

winstonma commented 1 month ago

Sorry for the misinformation. Yes I still got the blank tab.

@surapunoyousei I started floorp 11.17.7 using terminal, opened 3 tabs(tab1/tab2/tab3), combine tab1/tab2 together, and click tab3 afterwards. Then got the following error message on the terminal:

Assertion failure
assert@resource:///modules/AsyncTabSwitcher.sys.mjs:510:36
onLayersCleared@resource:///modules/AsyncTabSwitcher.sys.mjs:822:10
handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1139:16

Could you please take a look? Thank you very much.

surapunoyousei commented 1 month ago

It seems to happen only when the tab is reloaded in an unloaded state. It will take some time to fix as it reads code.

winstonma commented 1 month ago

Thank you very much. Could this ticket be opened? Thanks

Muko-Tabi commented 1 month ago

I think this should be opened, since it's a problem for people that use Sidebery (or similar) and can only use split view via keyboard shortcut.

surapunoyousei commented 1 month ago

Fixed

winstonma commented 4 days ago

@surapunoyousei I am using Floorp v11.18.1 and I recently saw this behavior.

  1. Opened some tabs
  2. Open 2 new tabs and use Split View on the 2 new tabs
  3. Open one new tab and I saw the following message on my my terminal
Assertion failure
assert@resource:///modules/AsyncTabSwitcher.sys.mjs:510:36
onLayersCleared@resource:///modules/AsyncTabSwitcher.sys.mjs:822:10
handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1139:16
JavaScript error: undefined, line 0: Error: r.tab is undefined
  1. After I type the URL I would see the blank page

But it is weird that I try to reproduce in private window but it didn't work. But I saw this weird behavior. Could you please take a look? Thanks a lot

winstonma commented 4 days ago

By the way when I

  1. Open terminal and type floorp --private-window
  2. Open 2 tabs and use split view
  3. Open a new tab then then I saw error log in the terminal
Assertion failure
assert@resource:///modules/AsyncTabSwitcher.sys.mjs:510:36
onLayersCleared@resource:///modules/AsyncTabSwitcher.sys.mjs:822:10
handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1139:16
Assertion failure
assert@resource:///modules/AsyncTabSwitcher.sys.mjs:510:36
onLayersCleared@resource:///modules/AsyncTabSwitcher.sys.mjs:822:10
handleEvent@resource:///modules/AsyncTabSwitcher.sys.mjs:1139:16

But when I type an URL it would show the content. Just wonder if it is expected behavior? Thanks

surapunoyousei commented 4 days ago

I assume it has been fixed, but are you still experiencing problems?

Ignore the console error.

winstonma commented 4 days ago

Also one more report on the split view:

  1. Open terminal and type floorp --private-window
  2. Open 1 tab (Call Tab1), go to www.espn.com
  3. Open a new tab 2, go to google.com
  4. Use split view on Tab1 and Tab2
  5. Open a new tab (Tab 3), go to three.com
  6. Swap the position of Tab2 and Tab3, now Tab2 is the rightmost tab
  7. Keep switching tabs like the video below

https://github.com/user-attachments/assets/a9c4d21c-2ca9-4d44-9fe1-39cf62996765

There are several things to notice

  1. Split View Content is swapped (In the split view, left hand side should show espn.com, but now it is on the right hand side)
  2. Tab3 content is disappeared some time, but after several switches it would come back
lonnyshoal commented 4 days ago

This issue has been fixed. However, I know there is another issue on the split view function: The newly-opened tab page is blank sometimes and temporarily. The page can be recovered after switching pages. I think we need more tests on all Windows, Mac OS and Linux platforms.

winstonma commented 3 days ago

@lonnyshoal I think your observation matches my recorded video.