[Bug]: media.block-autoplay-until-in-foreground not working

FGD-Garuda commented 1 month ago

Pre-Submission Checklist

[X] I have checked the existing/closed issues to ensure this issue has not already been reported.
[X] I am using the latest supported version of the browser.
[X] I have tried disabling all browser extensions/add-ons to rule out interference from these.
[X] I have tried clearing the browser cache and cookies.
[X] I have checked with a new profile and the issue still occurs.
[X] I have provided detailed step-by-step instructions on how to reproduce the issue.
[X] I have included relevant screenshots or console outputs.
[X] I have checked that this problem is not occurring in the latest version of Firefox ESR.
[X] This issue is specific to this browser and does not occur in other browsers.

Bug Summary

The config media.block-autoplay-until-in-foreground in about:config is not working, whether set to TRUE or FALSE, it ignores the setting and thinks it's FALSE.

This very useful feature is working fine out of the box on Firefox ESR 128 and also Nightly 131.

Reproduction Steps

Install Floorp 11.17.5
Fetch https://www.youtube.com
Search for anything in order to get a list of videos
Right-click on any one in the list and open it in a background tab

Expected Behavior

The background tab should BLOCK autoplay, like this: Screenshot_1

Actual Behavior

Instead, it plays the video: Screenshot_2

Screenshots

In FF Nightly, as well as ESR 128, the same configs are set as in Floorp: Screenshot_3

Except for Nightly, as well as ESR 128, the autoplay-until-in-foreground feature works.

Browser Version

11.17.5

Operating System

Arch Linux

Additional Context

I have tried a numerous amount of configs and none made it work.
I read this thread, but I cannot easily downgrade ffmpeg, as there are dependencies:
I found one half-decent workaround, which is to Block Audio on the website, instead of Allow Audio&Video. This prevents background tab from autoplaying, but it does not autoplay when you bring it to foreground, you have to manually click either on the video or on the tiny PLAY button, depending on the website. This adds steps, time and multiply by the number of videos some people can load in background it adds up. Which is why it's only a half-decent workaround.

Since this is working with both FF ESR 128 and Nightly 131, I was wondering if something got impacted during the Floorp build process?

creeper-0910 commented 1 month ago

Wait, it doesn't work with ESR128?

FGD-Garuda commented 1 month ago

Wait, it doesn't work with ESR128?

Where did I write that? I will correct immediately.

It DOES work with ESR 128. You set it to TRUE and the Autoplay is blocked. You set it to FALSE and the Autoplay is not blocked.

creeper-0910 commented 1 month ago

Ah, I must have misunderstood “Except for Nightly, as well as ESR 128”.Sorry.

surapunoyousei commented 1 month ago

I believe this issue has been resolved. Please check the latest version

FGD-Garuda commented 1 month ago

I believe this issue has been resolved. Please check the latest version

On v11.17.7 I have the exact same behavior as 11.17.5 from my OP, which is that specific config does take effect when set to TRUE (which is the default) and always behaves as FALSE.

CelestialCrafter commented 1 month ago

I believe this issue has been resolved. Please check the latest version

On v11.17.7 I have the exact same behavior as 11.17.5 from my OP, which is that specific config does take effect when set to TRUE (which is the default) and always behaves as FALSE.

Getting the same behaviour on v11.17.7 aswell

FGD-Garuda commented 1 month ago

Hi @surapunoyousei , since I don't seem to be alone with this behavior, is it possible to re-open this potential bug?

I don't think it gets a lot of attention being in the closed section.

Thanks

tk-master commented 1 month ago

This prevents me from using the browser honestly.. I'm forced to stay with floorp-11.15 because of this, please fix it.. autoplay is unusable when everything starts playing in the background because you opened a couple of youtube tabs.. lol seems like an obvious thing to priority fix

pa1kia commented 1 month ago

this used to work fine, but i also noticed that it broke after the update. very frustrating to lose this functionality.

surapunoyousei commented 1 month ago

We ask that you avoid unnecessary comments.

knot2006 commented 3 weeks ago

11.18.0 (64-bit) Windows Still does not work for me

Add-ons like this dont help/work as well: https://addons.mozilla.org/en-GB/firefox/addon/enhancer-for-youtube/

surapunoyousei commented 3 weeks ago

I am currently working on a solution to this problem.

FGD-Garuda commented 3 weeks ago

I am currently working on a solution to this problem.

Thank you very much!!

surapunoyousei commented 3 weeks ago

Hey. I find the way to fix this issue. This patch will send to Daylight build first. After pass the test, This patch will available stable version of Floorp. Thank you for your help.

If you would like to help us debug, please visit https://github.com/Floorp-Projects/Floorp/releases/beta to try the beta version.

My fixes will be added within 6 hours.

CelestialCrafter commented 3 weeks ago

works on daylight 11.18.1/20240907053122! thank you!

FGD-Garuda commented 3 weeks ago

Yes!! Me too it works!! 😃

surapunoyousei commented 3 weeks ago

I will deploy this fix. Thanks

CelestialCrafter commented 3 weeks ago

close issue ?

Floorp-Projects / Floorp