Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
6k stars 168 forks source link

[Bug]: Extra padding on first tab under pinned tabs on vertical tab bar #1383

Open kgorol opened 2 months ago

kgorol commented 2 months ago

Pre-Submission Checklist

Bug Summary

As you can see on the screenshot below, the first tab under pinned tabs (below Tuta) as some extra padding on the left.

Reproduction Steps

  1. Enable vertical tabs

Expected Behavior

No extra padding

Actual Behavior

Extra padding visible on first not pinned tab

Screenshots

image

Browser Version

11.17.5

Operating System

Windows 11

Additional Context

No response

Cl00m commented 2 months ago

I have just noticed that too. I believe this is attributed to the fact that the sidebar in Floorp has some additional elements (compared to FF). I have not yet attempted any related CSS hacks in floorp, and any tips about this would be greatly appreciated. Floorp 11.17.6, Win10 pro 22H2 19045.4780

Eragonfr commented 2 months ago

I can't reproduce it in floorp, but I sent a patch for the new vertical tabs on firefox.
Firefox hardcoded the padding on the first tab after the pined tabs to be on the left of the tab. The fix is as easy as adding three lines of css to move the padding on the top when the tabs are displayed vertically.

almighty-loaf commented 2 months ago

I'm also seeing this issue in Win11, and want to note a few more things:

  1. The "Pinned" sub-label is also missing for all pinned tabs
  2. Pinning a tab will correctly add the "Pinned" sub-label, but only for that tab