Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
5.64k stars 158 forks source link

[Bug]: Native messaging does not work #1385

Closed stilgarwolf closed 2 weeks ago

stilgarwolf commented 2 weeks ago

Pre-Submission Checklist

Bug Summary

Extensions using native messaging are not working.

Reproduction Steps

  1. _Install any extension using native messaging. (Try KeePassXC-Browser)

Expected Behavior

Extension must work, like in Firefox.

Actual Behavior

Extension does not work.

Screenshots

image

Browser Version

11.17.6 (64-bit)

Operating System

Debian unstable

Additional Context

I wrote a small extension and I found Floorp is using wrong directory when checking native messaging application json file: "$HOME/.mozilla/native-messaging-hosts" instead of "$HOME/.floorp/native-messaging-hosts"

Workaround: For above example, moving "org.keepassxc.keepassxc_browser.json" file to "$HOME/.mozilla/native-messaging-hosts/" folder solves the issue.

surapunoyousei commented 2 weeks ago

Hmm....

surapunoyousei commented 2 weeks ago

It makes sense to fix this, so I'll investigate.

creeper-0910 commented 2 weeks ago

Sorry, I made a mistake.

surapunoyousei commented 2 weeks ago

Hey! Did you check latest version?

stilgarwolf commented 2 weeks ago

Hey! Did you check latest version?

Yes, 11.17.7 (64-bit), Debian SID Still not working.

noizo commented 2 weeks ago

I use Enpass password manager, which is 99% also uses native messaging. Everything works fine in Floorp.

surapunoyousei commented 2 weeks ago

image

surapunoyousei commented 2 weeks ago

The latest version already seems to work.

Try the PPA version of Floorp. I'm assuming this issue is complete since we are getting a working environment again.

stilgarwolf commented 2 weeks ago

No, it's not working.

(I am already using Floorp from PPA)

KeePassXC puts "org.keepassxc.keepassxc_browser.json" file in .mozilla folder when enables Firefox browser. Moving the file to .floorp makes the extension unusable. Re-enabling Firefox in KeepassXC desktop app recreates json file in .mozilla folder.

The extension works with Floorp, but using .mozilla folder.

With LibreWolf, KeePassXC correctly uses .librewolf folder, so it seems Floorp is reporting wrong location of "native-messaging-hosts" folder.

surapunoyousei commented 2 weeks ago

Sorry, but Floorp intentionally uses the .mozilla folder.

This is because native applications place files to communicate with extensions in the .mozilla folder.

Using (by user) the .floorp folder would be confusing and difficult to use for users who are not familiar with difficult concepts such as hidden folders!

stilgarwolf commented 1 week ago

Using both .floorp and .mozilla folders would be better, I think. And, at least, write a notice about it.