[Bug]: Workspace is using idle CPU

gunir commented 2 weeks ago

Pre-Submission Checklist

[X] I have checked the existing/closed issues to ensure this issue has not already been reported.
[X] I am using the latest supported version of the browser.
[X] I have tried disabling all browser extensions/add-ons to rule out interference from these.
[X] I have tried clearing the browser cache and cookies.
[X] I have checked with a new profile and the issue still occurs.
[X] I have provided detailed step-by-step instructions on how to reproduce the issue.
[X] I have included relevant screenshots or console outputs.
[X] I have checked that this problem is not occurring in the latest version of Firefox ESR.
[X] This issue is specific to this browser and does not occur in other browsers.

Bug Summary

After I've measured pretty thoroughly, I'm 100% confident that Floorp Workspace is causing itself to waste extra CPU cycle for no reason, please take a look at this:

This is Floorp with Workspace enabled and Task Manager:

This is Floorp with Workspace disabled and Task Manager:

Reproduction Steps

Open Task Manager
Enable/Disable Workspace
Check Idle CPU Usage

Expected Behavior

Floorp should use about 0-0.25% CPU when idle with Workspace enabled

Actual Behavior

Floorp is using 3-4.5% CPU when idle with Workspace enabled

Screenshots

This is Floorp with Workspace enabled and Task Manager:

This is Floorp with Workspace disabled and Task Manager:

Browser Version

11.17.7

Operating System

Linux Lubuntu

Additional Context

All explained.

gunir commented 2 weeks ago

What is this?

It's virus, delete his post.

creeper-0910 commented 2 weeks ago

What is this?

It's virus, delete his post.

I recommend that you report it to github. We will remove it after a few minutes.

gunir commented 2 weeks ago

What is this?

It's virus, delete his post.

I recommend that you report it to github. We will remove it after a few minutes.

This repo doesn't allow user to report post, I basically can't

creeper-0910 commented 2 weeks ago

Deleted.

gunir commented 2 weeks ago

I confirm the issue still exists on latest version of Floorp 11.17.8:

surapunoyousei commented 2 weeks ago

Floorp's workspace runs on top of a complex code consisting of 20,000 lines of code to ensure proper operation.

This is the intention, but the problem will soon be solved as Floorp 12 will synchronize workspaces in multiple windows!

gunir commented 2 weeks ago

This is the intention, but the problem will soon be solved as Floorp 12 will synchronize workspaces in multiple windows!

Are we shifting from hidden tab API to hidden window API ? This sounds pretty good and performant to me, so iiuc:

Create a new workspace -> Create a new hidden window -> Create a workspace switching menu for above workspace
Switch between workspaces -> Hide current window -> Unhide hidden window for target workspace

If that's how it is, it would be very promising and stable, both Windows and Linux support this out of the box, API to hide and unhide windows, and Firefox by itself supports session saving of multiple windows out of the box too, as long as the user don't close window one by one.

gunir commented 1 week ago

I find this to be interesting, Zen Browser also has the similar Workspace feature, but it doesn't share the same idle CPU issue as Floorp, the only function that it's lacking is Container Workspace, but it shouldn't be the issue anyways.

surapunoyousei commented 1 week ago

As is clear from the functionality, Floorp's workspace is organized by window.

This is the reason.

Floorp-Projects / Floorp