Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
6.09k stars 170 forks source link

[Bug]: PWAs report incorrect URL #1446

Open Octelly opened 2 months ago

Octelly commented 2 months ago

Pre-Submission Checklist

Bug Summary

PWAs report incorrect URLs to extensions. image In this example, Bitwarden is showing me GitHub logins on Feishin, even though it's supposed to be showing my Navidrome login Screenshot_20240922_172131 and does so when Feishin is not open as a PWA image

Reproduction Steps

  1. Open a website as a PWA
  2. Try to use an extension that uses related API calls (not an extension dev)

Expected Behavior

Same behavior as when site is not open as a PWA

Actual Behavior

See Bug Summary

Screenshots

See Bug Summary

Browser Version

11.18.1 (64-bit)

Operating System

Arch Linux (Tested on NixOS Unstable as well)

Additional Context

I am aware that PWAs are still experimental and I am not expecting this issue to be resolved quickly. Just reporting it because I have not found it among reported issues and it does degrade my experience of using this otherwise wonderful browser.

surapunoyousei commented 2 months ago

Until 11.7.0 Floorp was reporting the correct URL for extensions in the PWA window, but due to problems I changed it to report the URL in the main window.

I do not plan to fix this at this time as I believe the ad blocker and other features are working fine.

The reason for this is that the extension that creates tab groups has a problem that deletes pages that are open in the PWA window.

Octelly commented 2 months ago

@surapunoyousei Thank you for the explanation. If this is the case, I'll just wait for PWAs to become more mature and try to deal with the issue in other ways in the mean time. Thank you for your time and effort.

(I would like to however keep the issue open until it is actually resolve if you don't mind - could be useful to others and I'll get notified once the newest Floorp version resolves it)