Web Apps Not Showing in Application Menu in Linux Env

p134c0d3 commented 8 months ago

Pre-Submission Checklist

[X] I have checked the existing/closed issues to ensure this issue has not already been reported.
[X] I am using the latest supported version of the browser.
[X] I have tried disabling all browser extensions/add-ons to rule out interference from these.
[X] I have tried clearing the browser cache and cookies.
[X] I have tried to create a new profile and the issue still occurs.
[X] I have provided detailed step-by-step instructions on how to reproduce the issue.
[X] I have included relevant screenshots or console outputs.
[X] I have checked this problem is not ocurring in the latest version of Firefox ESR.
[X] This issue is specific to this browser and does not occur in other browsers.

Bug Summary

Hello, I know that Web App support is very experimental in Floorp right now, but submitting this so it can be looked at. 🙂 I'm using Linux as my main OS, and whenever I install a site as a web app (both from URL bar and web apps menu), the relevant .desktop file isn't being found in my applications folder, so I'm not able to find that web app among my applications. If I use the menu, then I'm able to open the web app, but I would expect to be able to open the web app from my applications menu. I have tested this both from the Gnome desktop and the Sway environment with the same result.

The below is showing the installed Google web app is not appearing at all in my applications

Reproduction Steps

Install any site as a Web App
Open application menu
Search newly installed Web App

Expected Behavior

To be able to have the Web App that I installed to show up in the list of my applications

Actual Behavior

Installed web apps do not appear in my applications list, whether by searching or scrolling. I have to open the web app from the Floorp browser instead of being able to open it from my applications menu.

Screenshots

image
[Screencast from 2024-02-19 08-53-37.webm](https://github.com/Floorp-Projects/Floorp/assets/70922864/96b972f1-8573-4398-9450-1a0838bce649)

Browser Version

11.10.0

Operating System

Garuda Linux (Arch based)

Additional Context

If the video did not attach correctly, let me know and I can send it another way.

surapunoyousei commented 8 months ago

Not Bug

p134c0d3 commented 8 months ago

@surapunoyousei May I ask how this is not a bug? When installing a web app, it is expected for it to show up in the normal applications menu as creating a Progressive Web Application is usually for that exact reason. To easily access the app without having to navigate to the browser. Brave and other Chromium browsers have this behavior, and for web app capability in a browser, is what anyone would expect.

surapunoyousei commented 8 months ago

As mentioned in the release notes, this is because it is still experimental and has not yet been implemented on Linux and Mac.

We are not going to do it because we have not established the technology at this time.

PR is welcome.

p134c0d3 commented 8 months ago

That's fair, I figured it didn't have to be closed, maybe set on the backburner to later, that way others can see it's still an issue, and something to be worked on (either by contributor or anyone), so could potentially we reopen this as an enhancement/needs contributors? I'm still learning the technology as well, but as soon as I get to a point where I think I can tackle it, I'd be more than happy to.

p134c0d3 commented 8 months ago

@surapunoyousei if you can direct me to where the web app code is in the repo, I will take a look.

surapunoyousei commented 8 months ago

This issue is pinned

surapunoyousei commented 8 months ago

https://github.com/Floorp-Projects/Floorp-core/blob/main/browser/components/ssb/SiteSpecificBrowserService.sys.mjs

p134c0d3 commented 8 months ago

Thank you!

TheChilledBuffalo commented 7 months ago

There is a workaround for this issue, but I must admit it is a bit tedious. You can manually write your .desktop files!

First go to Settings > Manage Profiles > Open Root Directory of the profile you use. The name of this directory, i.e., your profile name, is important. It should be something like, {randomLetters}.default-release.

Now open the ssb folder in that directory. You'll see an ssb.json file. Open it and use your editor's find feature and locate "id" (with double quotes).

There should be around two of those for each app. Copy the id with random letters (including the curly brackets). You can check which app's ID that is by checking the "name" right next to the "id".

Here the ID of my GitHub app is {118979dc-7e7b-4381-bd4d-041f6eee4559}.

Also download the website's icon from the internet.

Next fire up your favourite text editor and follow my example below. I'm using GitHub as an example. Replace the name and the ID with whatever you found out above.

[Desktop Entry]
Name=GitHub
Exec=floorp --start-ssb "{118979dc-7e7b-4381-bd4d-041f6eee4559}" --profile "path/to/your/profile/directory"
Terminal=false
Type=Application
Icon=/path/to/downloaded/icon

Note: If you are using the flatpak version, replace floorp in Exec with flatpak run one.ablaze.floorp.

Now save the file as /home/{User}/.local/share/applications/GitHub.desktop

If all goes well, you should be able to launch your Web App from your Applications menu now.

TheChilledBuffalo commented 7 months ago

Ok so this issue has been fixed.

https://github.com/Floorp-Projects/Floorp-core/pull/63

If all goes well, and we get flatpak permissions (link to PR), this feature should be a part of Floorp version 11.12.0

Mikilio commented 3 months ago

I still seem to have the same issue on NixOS though.

EDIT: fixed now

Floorp-Projects / Floorp