Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
5.74k stars 161 forks source link

[Bug]: padding on the top when using vertical tabs #964

Closed Minnona closed 7 months ago

Minnona commented 7 months ago

Pre-Submission Checklist

Bug Summary

After the latest update there's a padding or a box on top of the address bar, can't remove it.

Reproduction Steps

  1. Turn on vertical tabs
  2. Suffer

Expected Behavior

No padding

Actual Behavior

Yes padding!

Screenshots

image

Browser Version

11.10.5 (64-bit)

Operating System

Windows 11

Additional Context

No response

CutterKnife commented 7 months ago

Check for the same issue, including closed ones. BTW, this will be an option in the future.

Release notes:

スクリーンショット 2024-02-28 3 43 22
Axenide commented 7 months ago

Same here, maybe there is an option to disable it but I didn't find any.

surapunoyousei commented 7 months ago

Deplicate

sr-tream commented 7 months ago

Deplicate

Can you post link please? May be existed workaround to disable this?

surapunoyousei commented 7 months ago

Drag space will be able to be disabled in the next update in 2 weeks

JimFlasch commented 7 months ago

How about disabling it now????????????

JimFlasch commented 7 months ago

Should have had an options to disable this right from the start!

sr-tream commented 7 months ago

How about disabling it now????????????

Temporary I just revert commit what adds it in floorp-core for self

diff --git a/browser/base/content/browser-tabbar.js b/browser/base/content/browser-tabbar.js
index b16e3c2..1cccf1e 100644
--- a/browser/base/content/browser-tabbar.js
+++ b/browser/base/content/browser-tabbar.js
@@ -66,12 +66,8 @@ const tabbarDisplayStyleFunctions = {
             display: none !important;
           }
           #titlebar {
-            display: inherit;
             appearance: none !important;
-            padding-top: 10px;
-          }
-          :root[sizemode="fullscreen"] #titlebar[id] {
-            flex-basis: auto;
+            display: none !important;
           }
           #TabsToolbar #workspace-button[label] > .toolbarbutton-icon,
           #TabsToolbar #firefox-view-button[flex] > .toolbarbutton-icon {
diff --git a/browser/base/content/browser-verticaltabs.js b/browser/base/content/browser-verticaltabs.js
index e5bb9a5..843f71b 100644
--- a/browser/base/content/browser-verticaltabs.js
+++ b/browser/base/content/browser-verticaltabs.js
@@ -81,6 +81,8 @@ var gFloorpVerticalTabBar = {
     Services.prefs.setBoolPref("floorp.browser.tabs.verticaltab", true);
     Services.prefs.setIntPref("floorp.browser.tabbar.settings", 2);

+    document.getElementById("nav-bar-customization-target").style.paddingTop = "10px"
+
     // Move Tab Bar
     this.browserBox?.prepend(this.tabsToolbar || "");

@@ -187,6 +189,8 @@ var gFloorpVerticalTabBar = {
       "scrollbox",
     );

+    document.getElementById("nav-bar-customization-target").style.removeProperty("padding-top")
+
     // Observer
     if (this._widthObserver) {
       this._widthObserver.disconnect();
JimFlasch commented 7 months ago

What am I supposed to do with that code? (putting it in chrome.css didn't work.)

sr-tream commented 7 months ago

What am I supposed to do with that code? (putting it in chrome.css didn't work.)

  1. Clone the Floorp repo
  2. Initialize all submodules
  3. Apply this patch to floorp-core submodule
  4. Build Floorp
JimFlasch commented 7 months ago

Yeah... I'd prefer something easier.

JimFlasch commented 7 months ago

Oh, BTW - could you put up an English-language version of your website for those of us who don't know Japanese?

JimFlasch commented 7 months ago

And next time they make a change like this that they should know not everyone will want, they should include an option to disable it from the get-go!

surapunoyousei commented 7 months ago
#titlebar[id] {
  display: none;
}

add this text to userchrome.css

surapunoyousei commented 7 months ago

Issue is locked to make my comment stand out