search

Floppy / jekyll-test

A highly opinionated test configuration for Jekyll sites
MIT License
21 stars 0 forks source link

Move SRI check to check_external_links task #9

Closed vllur closed 6 years ago

vllur commented 6 years ago

Hi!

Sometimes builds are failing on SRI check when parsing a link tag in which SRI shouldn't be, e.g.: when using paginator and SEO plugins, which results in <link rel="next" href="https://example.org/page/2" /> failing to the lack of SRI.

In this case the link is both absolute and not the same as current page link, which throws the error. As far as I've looked this link can't be changed without "hacking" gems.

I would suggest (maybe temporarily) moving this check to external links task, for informational purposes only (or something else that will prevent this behaviour). It also wouldn't break whole builds (I believe many people don't have this in their websites).

vllur commented 6 years ago

Related Travis log: https://travis-ci.org/vllur/jekyll-new/jobs/450286442

vllur commented 6 years ago

Well, I've made PR to fix that in the html-proofer: https://github.com/gjtorikian/html-proofer/pull/496, so I'm closing this issue.

Floppy commented 5 years ago

Thanks!