search

Florian-Barthel / splatviz

Full python interactive 3D Gaussian Splatting viewer for real-time editing and analyzing.
MIT License
1.14k stars 75 forks source link

WRONG #23

Closed CauchyIntegrah closed 3 months ago

CauchyIntegrah commented 3 months ago

imgui is written in CPP, it is not a native Python library. Reference to README.md

BenMcAvoy commented 3 months ago

Is this referring to the comment in the README?

"This interactive viewer allows you to display and edit 3D Gaussian Splatting scenes in real time. By using a native python GUI library (imgui)"

CauchyIntegrah commented 3 months ago

Is this referring to the comment in the README?

"This interactive viewer allows you to display and edit 3D Gaussian Splatting scenes in real time. By using a native python GUI library (imgui)"

Yes.

BenMcAvoy commented 3 months ago

Could you make a pull request?

CauchyIntegrah commented 3 months ago

Added Fix in PR #24

Florian-Barthel commented 3 months ago

Splatviz is using pyimgui (https://pyimgui.readthedocs.io/en/latest/reference/imgui.core.html), which is a python wrapper for the cpp library imgui. I was just referring to pyimgui as imgui, since this is the package name when installing it with pip and when using it in the code. Nevertheless, calling it a native python library is WRONG :). That is true and I will change that.

I just wanted to empathize that there is no other programming language involved for developing and running splatviz (like a js frontend or some cpp files that have to be compiled as in the SIBR viewer).

I hope this resolves this issue!

Florian-Barthel commented 3 months ago

I will close this issue for now. Feel free to reopen it, if you think it is still WRONG.