FlorianHeigl / nagios

A lot of Check_MK and Nagios checks and code
11 stars 7 forks source link

check_mk edac plugin needs small patch #1

Closed Mrten closed 8 years ago

Mrten commented 8 years ago

I've got this:

root@idd0019:/sys/devices/system/edac/mc# ls -l
total 0
drwxr-xr-x 18 root root    0 Apr 16 22:19 mc0
drwxr-xr-x 18 root root    0 Apr 16 22:19 mc1
drwxr-xr-x  2 root root    0 Apr 16 22:21 power
lrwxrwxrwx  1 root root    0 Apr 16 22:19 subsystem -> ../../../../bus/edac
-rw-r--r--  1 root root 4096 Apr 16 22:19 uevent

there's directories beside mc0 and mc1, so the plugin generates warnings each time it runs.

root@idd0021:/var/log# /usr/lib/check_mk_agent/plugins/edac
<<<edac>>>
mc0 csrow0 32768 Registered-DDR3 0 0 S4ECD4ED
mc0 csrow1 32768 Registered-DDR3 0 0 S4ECD4ED
mc0 csrow2 32768 Registered-DDR3 0 0 S4ECD4ED
mc1 csrow0 32768 Registered-DDR3 22 0 S4ECD4ED
mc1 csrow1 32768 Registered-DDR3 0 0 S4ECD4ED
mc1 csrow2 32768 Registered-DDR3 0 0 S4ECD4ED
cat: /sys/devices/system/edac/mc/power/csrow*/size_mb: No such file or directory
cat: /sys/devices/system/edac/mc/power/csrow*/mem_type: No such file or directory
cat: /sys/devices/system/edac/mc/power/csrow*/ce_count: No such file or directory
cat: /sys/devices/system/edac/mc/power/csrow*/ue_count: No such file or directory
cat: /sys/devices/system/edac/mc/power/csrow*/edac_mode: No such file or directory
power csrow*
cat: /sys/devices/system/edac/mc/subsystem/csrow*/size_mb: No such file or directory
cat: /sys/devices/system/edac/mc/subsystem/csrow*/mem_type: No such file or directory
cat: /sys/devices/system/edac/mc/subsystem/csrow*/ce_count: No such file or directory
cat: /sys/devices/system/edac/mc/subsystem/csrow*/ue_count: No such file or directory
cat: /sys/devices/system/edac/mc/subsystem/csrow*/edac_mode: No such file or directory
subsystem csrow*

small patch:

Index: edac
===================================================================
--- edac    (revision 26716)
+++ edac    (working copy)
@@ -24,7 +24,7 @@
 # mc0 csrow0 8192 Registered-DDR3 0 0 S4ECD4ED
 # EDAC memory driver running
 # Iterate all memory controllers, print memory info and EDAC mode. Maybe later add DIMM label support.
-for mc in /sys/devices/system/edac/mc/* ; do
+for mc in /sys/devices/system/edac/mc/mc* ; do
     test -d  $mc || break
     for csrow in $mc/csrow* ; do
FlorianHeigl commented 8 years ago

I applied the change in bitbucket, it should sync over soon. Please reopen if you don't see it showing up.

Mrten commented 8 years ago

thanks!