search

FlorianPfisterer / vpc-flow-log-analysis

Analyze and visualize VPC flow logs from AWS.
MIT License
43 stars 15 forks source link

S3 download limited to 1000 files #6

Open gustavebbers opened 2 years ago

gustavebbers commented 2 years ago

Very nice utility to visualize our traffic. I was missing some ip adresses which should have been there.

It seems 's3.listObjects' only retrieves up to 1000 files. For more files pagination should be added.

https://github.com/FlorianPfisterer/vpc-flow-log-analysis/blob/3c68c4bc1b3a15fff86e5824c826a3b2f220c042/graph-generator/s3-download.ts#L35

FlorianPfisterer commented 2 years ago

Good point! Feel free to submit a PR that addresses this.

stackErr-NameNotResolved commented 2 years ago

This functionality will be fixed in #7