search

FlorianPommerening / FingerJoints

Fusion 360 add-in for creating finger joints
128 stars 11 forks source link

Add option for tolerances #2

Closed FlorianPommerening closed 3 years ago

FlorianPommerening commented 3 years ago

Something that came up in the Fusion forum: it might be useful to have an option for a configurable tolerance between the fingers. This would be a small gap between each two fingers that is cut out of both parts.

it-ony commented 3 years ago

+1 for this. I'm using this awesome add-in from you now for building a lot of shelves and boxes for my camper van. Manufacturing this with CNC is a pain in the ass, as its too accurate to manufacture it out of wood and putting the pieces together.

I might contribute.

FlorianPommerening commented 3 years ago

I started implementing this today (https://github.com/FlorianPommerening/FingerJoints/pull/4). Documentation is still missing and the feature is not merged yet. If you would like to test it, you could try running the code on branch issue2.

it-ony commented 3 years ago

Seems like we worked at the same time at the same feature... https://github.com/it-ony/FingerJoints/tree/tolerances

it-ony commented 3 years ago

Comparing the solution, it's quite similar. But, was nice playing around with the fusion 360 api. Still I'm a little said ;) I tested yours, and it works.

FlorianPommerening commented 3 years ago

Playing around with the Fusion API was the main motivation behind this plugin for me :smile: Sorry you had some duplicated work but good to see that the solutions are similar. I saw that you had some code beautification and a fix to the stop method in there as well. If you want to send a pull request for those, I can merge it.

FlorianPommerening commented 3 years ago

I pulled some changes from your commits and added a new release (v.1.1) that includes the feature.