windows glfw3.x64 dll appears to be incorrect

FlorianRhiem / pyGLFW

Python bindings for GLFW

MIT License

232 stars 36 forks source link

windows glfw3.x64 dll appears to be incorrect #37

Closed christopherhesse closed 4 years ago

christopherhesse commented 4 years ago

I downloaded glfw-1.8.5-py2.py3-none-win32.zip and glfw-1.8.5-py2.py3-none-win_amd64.zip from pypi and unzipped them:

md5 glfw-win*/glfw3.dll
MD5 (glfw-win32/glfw3.dll) = cc96a6eed5b83cc4521a16499ddf7187
MD5 (glfw-win_amd64/glfw3.dll) = cc96a6eed5b83cc4521a16499ddf7187

It looks like the packaging is messed up and that these are both the 32 bit dll, any ideas?

MD5 (glfw-3.3.bin.WIN32/lib-vc2010/glfw3.dll) = cc96a6eed5b83cc4521a16499ddf7187

FlorianRhiem commented 4 years ago

I suspect that this might be due to temporary files of running bdist_wheel being reused despite being passed different plat_name flag. Currently the script only deletes the files that are created on purpose. If that's not it I'll just have to isolate the build processes into differing CI jobs.

FlorianRhiem commented 4 years ago

Apparently the build directory is reused by bdist_wheel without checking correctly whether files had changed. By deleting it after building each wheel, this issue should be avoidable. These are the wheels created that way: dist.zip

FlorianRhiem commented 4 years ago

This was fixed in release v1.8.6.

christopherhesse commented 4 years ago

Thanks for fixing this!