FlorianUekermann / rustls-acme

Apache License 2.0
144 stars 28 forks source link

Consider returning events from `Incoming` #26

Closed FlorianUekermann closed 1 year ago

FlorianUekermann commented 2 years ago

Some events may be of interest to users of the simpler Incoming api. The exact item type is a bit tricky, because we already have a fully populated Result<TlsStream<Tcp>,TcpError>, which isn't easily extended with the event type, which covers both positive and error events. Relevant comment: https://github.com/FlorianUekermann/rustls-acme/pull/18#issuecomment-1136540419

adding a log_events() method, which filters out Events and does the appropriate logging may be a good idea, to get the current behavior without much extra code.