FlorianUekermann / rustls-acme

Apache License 2.0
136 stars 27 forks source link

Document relationship to rustls config better #34

Closed FlorianUekermann closed 10 months ago

FlorianUekermann commented 1 year ago

The relationship/interactions of this crate to rustls configs isn't very obviously documented. The high level methods on AcmeConfig also don't allow supplying your own rustls config. This may be good as is... or not. Maybe the high-level incoming() should be extended by adding a variant which gives the user more control over the rustls details via a callback (just providing may not be enough for all usecases as the reliance of this crate on checking alpn before picking a config demonstrates).

FlorianUekermann commented 1 year ago

See comments on #37 regarding handing over control to user after client hello