Closed hdevalence closed 1 year ago
Thanks for the opening the issue. Note that AcmeConfig
is used for both the low level and high level API in rustls-acme
. That's why it only offers configuration of acme related things. With the low level API you should be able to do what you want already (have a look at the low_level*.rs
examples).
But I do think it would be nice to offer at least basic alpn control via the simple API (on Incoming
).
rustls_config
and simply overwrite the resolver. That would also cover other rustls config changes the user wants to make.AcmeState::incoming_with_alpn(self, cb: Fn(rustls::ClientHello) -> ...)
)Maybe both. I'll see what I can come up with today. If you try the low level api and run into problems or have opinions/suggestions regarding the above, let me know.
I added an alpn_protocols
argument to all functions that construct Incoming
, which makes this available in the high-level api.
rustls-acme = { git = "https://github.com/FlorianUekermann/rustls-acme" }
In the long run I'm considering merging the low- and high-level APIs, by making the stream emit something similar to rustls::server::Accepted, which the user can turn into a stream using their own config. That would side-step the whole issue. But it is good to get this out the door first, so there's something to compare the new API to during development.
Please let me know if this works for you and if you have any usability concerns, so I can tag a release asap.
Amazing, thanks so much! We tested with a fork where we just hardcoded in ALPN settings and got things working, we'll try the patch now and let you know if it works.
Please let me know if this works for you and if you have any usability concerns, so I can tag a release asap.
We've tested and this works for us! If you'd be interested in #38, we could also submit a PR for that so you'd only have to do one release, but we'd also be happy to do that later if you'd prefer more deliberation. Whatever works.
published as 0.6.0
Hi, while trying to use
rustls-acme
withtonic
, we ran into problems that I think are related to not having the ability to configurerustls
ALPN settings. (Full context is here: https://github.com/penumbra-zone/penumbra/pull/1666#issuecomment-1504875450)Currently, the
rustls-acme
API doesn't allow settingrustls
ServerConfig
at all.Would it be preferable to expose the entire
ServerConfig
as part of theAcmeConfig
builder API, or just the ALPN settings?