search

FlorianWendelborn / atom-sorter

:signal_strength: :atom: package to sort things.
https://atom.io/packages/sorter
MIT License
5 stars 1 forks source link

Unable to sort if has default options #3

Open Noitidart opened 7 years ago

Noitidart commented 7 years ago

In javascript lots of times we have default values for arguments, something like this:

function({ foo, bar, qux=8, baz=9 })

Some people put spaces between the ='s sign.

If I highlight within the curlies and try to sort it fails. :(

FlorianWendelborn commented 7 years ago

I guess I'll have to implement an AST parser.

Noitidart commented 7 years ago

Thank you sir so much for your willingness to address this! I am super excited. I switched from Atom to VSCode, but am now switching back to Atom/Nuclide and am mising this sort feature I used to use on VSCode - https://github.com/henriiik/vscode-sort

FlorianWendelborn commented 7 years ago

@Noitidart I'm very busy with university and my job right now, don't expect this too quickly without a PR. I still want to do it (partly because I always wanted to implement a parser) but no idea when I'll find time as this issue isn't trivial to fix.

Noitidart commented 7 years ago

No problem, I really appreicate your note sir.