search

FlorianWendelborn / fritz-box

:package: Promise-based JavaScript FRITZ!Box API.
https://npmjs.com/package/fritz-box
MIT License
12 stars 5 forks source link

getWlanLog Function #4

Closed derN3rd closed 6 years ago

derN3rd commented 6 years ago

With this function you can get the last entries from your wlan log file. e.g. to see the last (dis)connected devices in your wlan

FlorianWendelborn commented 6 years ago

Hi, @derN3rd. Thank you for your contribution. I’m sorry that this is still not merged, currently very busy with work.

The code itself looks fine to me, and I’m sure it’ll also work. The main reason why I don’t just merge it is because I’ll need to find some time to also publish these changes.

If you don’t have any time pressure, I’d try to publish this Saturday.

derN3rd commented 6 years ago

No problem, take your time.

Another thing that might be interesting for you (if you have the time): Prettier That would ensure that the code formatting remains the same when multiple people are working on the project. I could do that for you, if you want.

FlorianWendelborn commented 6 years ago

@derN3rd Yes, that’s a good idea. I honestly didn’t notice that this project doesn’t have a prettier config yet. Mine applies globally in my editor when it can’t find one, so it looked fine for me. I’ll add one on Saturday.

5

FlorianWendelborn commented 6 years ago

@derN3rd I released this with a different (and more powerful) API in 1.2.0. Would be nice if you could check if this still works for your setup. The FRITZ!Box API is pretty weird.