search

FlorianWilhelm / zipline-poloniex

Poloniex bundle for zipline
MIT License
65 stars 13 forks source link

Fix for Issue #3 #4

Closed immackay closed 6 years ago

immackay commented 6 years ago

The 8 hour blocks just ensures that it stays under 50000 trades. The usdt_btc pair has a few days this year that have over 100000 trades each, which conflicts with the original code.

immackay commented 6 years ago

Hi Florian, not sure if you saw I pushed a final version of this fix with your suggestion implemented.

FlorianWilhelm commented 6 years ago

@immac636 thanks for pinging me again and your PR :-) I like it, would you be interested in becoming a collaborator in this project?

immackay commented 6 years ago

Sure, I'm likely to keep using this and tinkering with it. I can maintain it if you like.

FlorianWilhelm commented 6 years ago

@immackay , cool! Welcome on board! Feel free to commit improvements and ping me if you want to have something released on PyPI.