search

FlorianWilhelm / zipline-poloniex

Poloniex bundle for zipline
MIT License
65 stars 13 forks source link

Bitfinex #7

Open gelinger777 opened 6 years ago

gelinger777 commented 6 years ago

Hi there. This plugin looks great ... Need time to have deeper look. But a fast question. Which files need to be rewritten so that we could have one with bitfinex instead of poloniex. ? Do you think it would be hard to implement https://github.com/ccxt/ccxt ?

FlorianWilhelm commented 6 years ago

Hi @gelinger777, cool idea including ccxt. I think basically (without taking a deeper look at ccxt), one would need to replace api.py with a proper interface to ccxt. Overall it should not be that difficult, do you want to contribute a PR?

gelinger777 commented 6 years ago

we need some time thought but maybe yes. Only adapting api.py would be enought you think?

FlorianWilhelm commented 6 years ago

Yes, I assume that making instead of api.py a wrapper around ccxt should be fine but I haven't looked into it.

gelinger777 commented 6 years ago

I have forked your project, so I will play a bit. Lets see. I will come back to you later on if I have questions.

avoll commented 6 years ago

@gelinger777, I was just thinking along the same lines, although not for bitfinex, but for any ccxt supported exchange. We could collaborate potentially? @FlorianWilhelm, with your permissions, I'd like to fork and refactor for this.

FlorianWilhelm commented 6 years ago

@avoll, cool, go for it! Looking forward to your contribution.

gelinger777 commented 6 years ago

@avoll yes we can collaborate. would be interesting. I will try to find some time next week.

mayzenator commented 6 years ago

Hi! Has this been implemented yet?

avoll commented 6 years ago

Alas, not by me. I switched to a different solution soon after posting my interest.

It would not be much trouble to do it in ccxt, perhaps even directly implementing bundle interface.

On Wed, Feb 14, 2018 at 4:26 PM, Mayline Zhong notifications@github.com wrote:

Hi! Has this been implemented yet?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FlorianWilhelm/zipline-poloniex/issues/7#issuecomment-365750389, or mute the thread https://github.com/notifications/unsubscribe-auth/AYm0sRSXaHhxVCwpM5ck91-Sl17MrrWtks5tU0-cgaJpZM4QzYuv .