FlorianWilk / SpotMicroAI

SpotMicro AI - How to build a self-learning Robot
432 stars 88 forks source link

How about rewriting @? #1

Closed littleggghost closed 5 years ago

littleggghost commented 5 years ago

Hi, @FlorianWilk You did a really awesome job! I can't believe that you can model a Spot-like robot and get an nice achievement in control! There maybe has a "problem": It would be better if this code could support python2.7 and python3 simultaneously. But the grammar "@" in kinematics.py seems not supported in py2.7 which just means matrix multiplication. So, maybe replace the "@" by normal grammar is better? Or wait for my PR?

Best Regards!

FlorianWilk commented 5 years ago

Hi littleeggghost,

thanks a lot for the nice mail. Yes, you're right about the @-Issue. I am using Python3 since i also use it in my Jupyter-Notebooks, but yes, i will think about rewriting it to make it work with P2.7, too. Did the rest work for you? This Project is still at the very beginning so expect a lot of bugs :)

Regards, Florian

On Mon, May 27, 2019 at 8:52 AM littleggghost notifications@github.com wrote:

Hi, @FlorianWilk https://github.com/FlorianWilk You did a really awesome job! I can't believe that you can model a Spot-like robot and get an nice achievement in control! There maybe has a "problem": It would be better if this code could support python2.7 and python3 simultaneously. But the grammar "@" in kinematics.py seems not supported in py2.7. So, maybe replace the "@" by normal grammar is better?

Best Regards!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FlorianWilk/SpotMicroAI/issues/1?email_source=notifications&email_token=AA26L7S3QNK4OMTQRAO65ITPXOAJLA5CNFSM4HPZCKY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GV6Q6NQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AA26L7TOPO7PXFP4Q2JYTMTPXOAJLANCNFSM4HPZCKYQ .

littleggghost commented 5 years ago

Thanks for your reply! I will commit a PR to make it compatible with py2.7.