Open Aetherinox opened 9 months ago
Thank you for reporting this issue. I am currently using Font-Awesome-Solid from the premade custom icon packs (you can find these under Browse icon packs
) and it works perfectly without any issues.
Do you have some kind of reproduction vault, so that I can reproduce this issue more easily?
I'm running some tests at the moment for the "blank" icons. But I've also started a new vault, and all I've installed are two fontawesome 6 icon packs, fas, and fad
It shows the few icons I added, but for fas and fad, it shows the same icons.
I added all 4 of the icons in the list, and they appear to have the same names
:FaDog:
:FaDogLeashed:
:FaDog:
:FaDogLeashed:
It's not doing something like FasDog or FadDog. It's sticking to FaDog, and two icons from two collections collide.
Almost like it's taking only the first two characters of the name and using that. I'm going to make two new icon sets with different names and try.
Yeah, it's an issue with the first two characters being used. On my install, I can't have anything using the same first two characters, otherwise it works showing the correct icons
I'm going to go back to my original vault, back it up, and reinstall the icons with different abbreviations.
So that's the problem. No two icon packs can contain the same first two letters, otherwise they'll start overriding each other.
Once I uninstalled all the icons and re-added them using different abbreviations that didn't collide with others, it shows multiple icons fine.
Going to make for a pain with trying to remember which is which, because a few of the FA Pro icons have similar style names. I've looked through though, and apparently all the icons show and work fine now after I re-named their abbreviations. Not sure if you did that on purpose, or if you may change it up in the future to allow for maybe a way to name the icon pack, but also pick an abbreviation. That may help out a bit.
But up to you. As long as it works. And I've also got the ability to see icons now in Edit mode after your other update, so I'm happy.
Ok so it's basically an issue when the first two characters are the same and the icon name itself is also the same?
Yeah, it seems to be if you have icons of the same name, that also are in packs starting with the same two letters, it causes them to break, or one icon pack will take priority.
For FontAwesome, none of the icons are prefixed with anything. Just the name of the icon itself:
And for the main FontAwesome icon packs (Solid, Duotone, Sharp Thin) all have the same icon names.
So I've got the icon 00.png
from FAS conflicting with FAR. And it seems to use whichever ones got loaded first by the plugin.
Describe the bug Certain icons in the suggestion context menu appear blank. However, if you select one of the blank spots, the actual name of the icon appears in the note, but also doesn't show in either mode for Obsidian (Editing and Reading Mode). It just shows as the text to call the icon.
To Reproduce Steps to reproduce the behavior:
Expected behavior Shows icons
Screenshots This example is of me typing out the starting name of icons with
:check
to see what all matches I can find. Eventually no actual icons show and it's all blank boxes.Here is a list of the icon packages I have installed:![LpUtGJ0](https://github.com/FlorianWoelki/obsidian-iconize/assets/118329232/6b47d813-38aa-4542-9e6b-0761e6f3fe85)
Note
I do own and have Font-Awesome 6 Pro icons installed, but they should behave the same as the free ones or Font-Awesome 5. As shown in the 2nd screenshot of my icon list, I keep the conformity that Font-Awesome normally uses which is
far
: Font Awesome Regularfab
: Font Awesome Brandsfas
: Font Awesome Solidfad
: Font Awesome DualtoneHere is a small sample list of the icons that don't work
Seem to all start with
Fa
.I then took my entire vault and placed it into Visual Studio Code and went looking for any mention of these icons.
as an example, does have three images associated to it. But they are not![IRMqLvL](https://github.com/FlorianWoelki/obsidian-iconize/assets/118329232/01d64bbc-a225-449f-8ecf-f4f0a8db15b5)
Fa
However, these three icons are in the following locations:
I then went back to Obsidian and typed the name of that icon, and I do end up seeing three blank spots:
Yet some icons in that same structure work perfectly fine.
I went into the data.json file that is storing the folder icons, and I do see that it's using Fa and not Fas.
Those icons for the folder work fine. But if it's using Fa instead of Fas, that means that certain icons are not being loaded or are being overwritten?