search

FlorianWoelki / obsidian-iconize

Simply add icons to anything you want in Obsidian.
https://florianwoelki.github.io/obsidian-iconize/
MIT License
814 stars 56 forks source link

Wrong icon size for ITS theme #521

Closed TheDude2371 closed 1 month ago

TheDude2371 commented 1 month ago

Describe the bug Icons as part of a link text is huge

To Reproduce Steps to reproduce the behavior:

  1. Create a note. In the directory tree, give it an icon as part of the filename
  2. Create a link in another note that references back to that note with the icon. Make sure it has a Header (H1, H2, etc) marking at the start of the line
  3. Go to a new line, and when the header and link formatting resolves, the icon itself is massive.

Expected behavior Icon remains the same size as the text in the Header (with link)

Screenshots image

Additional context Originally thought to be an issue with link text and the icon. Turns out this is any icon that's part of a header, whether part of a link or not.

TheDude2371 commented 1 month ago

Second screenshot -- here you can see the Source Mode to see hat this has an H2 marking. image

Te link marking doesn't seen to enter into the problem at hand.

FlorianWoelki commented 1 month ago

Thank you for the report. What kind of theme do you use?

TheDude2371 commented 1 month ago

I use ITS for all of my vaults, as it works best for TTRPG, journals, writing, etc with all of its features.

Davve37 commented 1 month ago

I got the same issue. I am also using the ITS theme. https://i.imgur.com/RCom8lG.png

FlorianWoelki commented 1 month ago

This issue has been resolved in the latest release.

Davve37 commented 1 month ago

This issue has been resolved in the latest release.

The icons are still a bit big when appearing in the ITS > [!infobox] callouts specifically. Otherwise it looks good as far as I can tell. I don't have an issue with icons in a text (as links or plain text) or in the heading of other callout boxes.

6CKCW3P

FlorianWoelki commented 1 month ago

This issue has been resolved in the latest release.

The icons are still a bit big when appearing in the ITS > [!infobox] callouts specifically. Otherwise it looks good as far as I can tell. I don't have an issue with icons in a text (as links or plain text) or in the heading of other callout boxes.

6CKCW3P

Thank you for the quick response. I'll take a look at the issue with the callouts!

TheDude2371 commented 1 month ago

Still showing huge in Headers... not limited to ITS theme, tried in a barebones vault with default theme as well. image

image

It is pulling the icon as part of a file link, as the file/note does have a link in the manager on the left. image

FlorianWoelki commented 1 month ago

Hmm, for me, it's not behaving like this anymore. I do have the correct size for the headers and titles with any icon.

TheDude2371 commented 1 month ago

Even if it pulls the icon as part of a file link? Obsidian 1.6.7 ITS Theme 1.3 Iconize 2.14.3

Is there anything you could be doing different? I don't want to share this vault as it's chock full of information that I don't want public, it's for my personal use only. I just checked on both Linux and Windows versions, and behavior is the same.

My plugin settings: image image image

TheDude2371 commented 1 month ago

Okay... started a completely fresh vault as a test, and it's working as advertised. Wonder why I'm still getting that behavior. Will look at other plugins/settings.

TheDude2371 commented 1 month ago

Update... Uninstalled/reinstalled Iconize. Works now. Downside is I have to go through everything again to re-add all the file icons. :(

FlorianWoelki commented 1 month ago

That's unfortunate, sorry to hear that! Maybe there was an issue in the data.json file of Iconize?