Florianisme / WakeOnLan

A Wake on Lan Application for Android
https://play.google.com/store/apps/details?id=de.florianisme.wakeonlan
GNU General Public License v2.0
195 stars 17 forks source link

List of optional options could have lower priority #12

Closed fabianski7 closed 10 months ago

fabianski7 commented 1 year ago

Your app works great for sending the packet through devices over the local network, but I couldn't do it when I'm not on the internal network.

I tested the same configuration that I use (and that works) in this app.

Florianisme commented 1 year ago

Hi, that's odd. Especially if it's the same configuration. What's the Broadcast Address that you are using if you are waking your devices from the public internet (I don't want your actual value, just which device's address it is).

Is it for example the public IP of your router?

fabianski7 commented 1 year ago

I don't know what I did here :S

fabianski7 commented 1 year ago

I am sorry, I was confusing the fields "IP Status" with "Broadcast Address". That's why it didn't work.

But if I could suggest something to you, the "IP Status" field could be moved into a category of its own, just like "Security" is, and also moved lower down in the list of options. That way the optional fields would have less relevance and you would avoid situations like this. Or maybe create a category called "Optionals" and put SecureOn and IP Status together. You will know what is best.

Thank you very much for your work on this app, it works great!

Florianisme commented 1 year ago

Ah, glad it's not actually a programming error :) Yeah that could be an improvement.

The idea was that the status IP would be filled out so commonly that it doesn't make sense to hide it besides other options. I could however also add a small explanation below it, I'll see if that works.

Florianisme commented 1 year ago

What's your opinion on this? I also added a short explanation to the input image

fabianski7 commented 1 year ago

Much better!

Florianisme commented 1 year ago

Part of Beta 1.8.3 which rolled out right now

Edit: Note to myself: add missing translations for explanation text and extract into i18n

fabianski7 commented 1 year ago

thank you for your work!

Florianisme commented 1 year ago

I'll keep this open until it is published in production. Just to keep track :)

Florianisme commented 10 months ago

Released with 1.9.0