FloricSpacer / AbyssDiver

12 stars 12 forks source link

Add a `jsconfig.json` for VSCode and fix Character constructor jsdoc #102

Closed spikymoth closed 1 year ago

spikymoth commented 1 year ago

This adds a jsconfig.json, which allows VSCode to see the files as a project and makes cross-file references work. Right now files are treated as scripts, which means they can see each other's global declarations.

I also fixed the jsdoc comment for the Character class constructor to match how it's actually called. This allows VSCode to provide type information inside the class - for example, if you hover over this.events in a class method outside the constructor, it will now be properly typed as CharEvent[].

spikymoth commented 1 year ago

Made the same change to the AgeEvent constructor and fixed the semen demon check in the Bandit Conversations passage (it was missing a closing parenthesis).

spikymoth commented 1 year ago

Tidied up the semen demon checks a bit more, then made the indentation consistent across all .twee files (they all use tabs now). I don't mind using either spaces or tabs, but it bothered me that it wasn't consistent.