search

Florin-Popescu / vscode-unity-test-adapter

Unity Test Adapter Extension for VS Code
MIT License
5 stars 6 forks source link

Make space after "FAIL:" optional #10

Closed NovaNekmit closed 3 years ago

NovaNekmit commented 3 years ago

CMock may fail without a preceding space:

[...]\CMock\examples\temp_sensor\test\TestMain.c:14:testMainShouldCallExecutorInitAndContinueToCallExecutorRunUntilHalted:FAIL:Function Executor_Run.  Called fewer times than expected.
[...]\CMock\examples\temp_sensor\test\TestTemperatureFilter.c:37:testShouldResetAverageIfPassedInfinityOrInvalidValue:FAIL: Expected -inf Was nan

Unity tools deal with this just fine, but here the regex was to strict.

(Above output is reproducible by duplicating line 21 here: https://github.com/ThrowTheSwitch/CMock/blob/master/examples/temp_sensor/test/TestMain.c#L21 and running rake in the temp_sensor folder)

NovaNekmit commented 3 years ago

Hi again, are you waiting on more changes before pushing an update to the vscode marketplace?

Florin-Popescu commented 3 years ago

Hi, terribly sorry. Meant to include this in 0.0.6 in the marketplace but forgot to pull this commit before publishing.

Published 0.0.7 containing this fix now.

NovaNekmit commented 3 years ago

The extension package does not contain the fix. Not sure how the build works, but you didn't update the version in the package.json, maybe that has something to do with it?

And looking back over the changes now, i think the \ i added is superfluous.