FlorinTulba
commented
7 years ago Relevant commits from before May 17, 2017:
- motivated by SRP, ISP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/338ab50233e72384ecadbba31bf02045dad33b6b (...the symbols are sorted by average pixels sum... They are visualized differently...) CmapPerspective allows viewing symbols sorted by clusters, no matter the order in which they are actually compared against image patches
- motivated by SRP, ISP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/eace6fe6a0daed0b4a8282e0c2b2c745b9a8f2d3 (...Preselection by tiny symbols is now handled by the abstract factory PreselManager...)
- motivated by SRP, ISP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/03454b1bab1ea1f9a7df5e23aaf0a5beb41f0e11 (...Moved logic of the Skipping Matching Aspects outside MatchEngine...)
- motivated by OCP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/204406ab6cf26f528dcebd0ebcdb00df6be7ea45 (...Structural Similarity matching aspect can be configured from varConfig.txt which blur algorithm to use...) New blur algorithms leave existing interfaces as they are
- motivated by SRP, ISP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/5b2278ae99a92c42529deba86a47f0646041a6fd (...separated clustering code from rest)
- motivated by OCP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/75d63d86ef6496d532667bb36271a87fe55deda1 (Refactorized symbol filters...) PmsCont can report the count of symbols filtered out by new criteria without changing its interface
- motivated by SRP, ISP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/f12575bc210ecb7e5fd8715a31d28f7649d23fff (Divided Controller public methods in interfaces. Redesigned Timer. Re…)
- motivated by OCP and DIP: https://github.com/FlorinTulba/Pic2Sym/commit/544b4e1135a8e2ff2167b5ac38d68e64f56f0310 (Separation between MatchAspect-s and MatchEngine) MatchEngine can use new MatchAspect-s without changing its interface
- motivated by SRP: https://github.com/FlorinTulba/Pic2Sym/commit/c361cc0039442104fe394d6770c7c67f72411c16 (Split files and classes; Moved configurable content to separate files)
- motivated by SRP: https://github.com/FlorinTulba/Pic2Sym/commit/a881b1c65a6194463e4596da96ba32b72f1f7c64 (...Split Config in MatchSettings, ImgSettings and SymSettings...)
- motivated by SRP: https://github.com/FlorinTulba/Pic2Sym/commit/63cb43b2299687b9d494ed1c5d798ad292980575 (Using a Timer class for timing img transformations and updates of the…)
- motivated by SRP: https://github.com/FlorinTulba/Pic2Sym/commit/b45cd448df5ffd8868bff9c070523f7dd0a6d7ba (vector<PixMapSym> -> PmsCont to use same font size and precom…)
- motivated by SRP: https://github.com/FlorinTulba/Pic2Sym/commit/af07e4039c10c3e31c50f5d505cf0198255e3cce (Split MatchParams into MatchParams and Matcher)
Respecting the S.O.L.I.D. design principles helps during maintenance and when extending the project with new features. The commits addressing design optimizations should be mentioned under this issue.