Floris497 / mac-pixel-clock-patch-V2

993 stars 221 forks source link

High Sierra #222

Open pedrohex opened 6 years ago

pedrohex commented 6 years ago

Hi, The patch was working great until high sierra update. I've tried V1, V2, V3 and V4 with no results.. with V4 mac get stuck at startup and i must unpatch it.

MacbookPro 13 early 2011 Using Apple HDMI to Minidisplay port Monitor LG UltraWide 29UM59-P 2560x1080

Any ideas ? Thanks in advance

Floris497 commented 6 years ago

Nope, no idea yet.. v4 isn't ready

pedrohex commented 6 years ago

Thank you for your response Floris497. Please tell me if i can help some how.

Meanwhile , downgrading to sierra :(

gothickitty93 commented 6 years ago

just out of curiosity, is there a major difference between coredisplay in high sierra vs sierra due to more things running on Metal?

Floris497 commented 6 years ago

I remember the executible is serveral MB bigger.. not sure if that has to do with metal..

Bastani commented 6 years ago

Make sure you unpatch before using any of the following: You can either use this script which will unfortunately break Copy and Paste:

sudo perl -i.bak -pe 's|\xB8\x01\x00\x00\x00\xF6\xC1\x01\x0F\x85|\x33\xC0\x90\x90\x90\x90\x90\x90\x90\xE9|sg' /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay
sudo codesign -f -s - /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay

Or Lilu + CoreDisplayFixup which you have to compile yourself but should not have the copy and paste problem.

Both of the above have an issue with iTunes crashing. No idea how to fix it.

Credit to scottsanett for the above script

Floris497 commented 6 years ago

I was trying core displayfixup and lulu.. but I couldn't see if it was working or not.. maybe it's the future :)

yverbin commented 6 years ago

try it: sudo perl -i.bak -pe 's|\xB8\x01\x00\x00\x00\xF6\xC1\x01\x0F\x85|\x33\xC0\x90\x90\x90\x90\x90\x90\x90\xE9|sg' /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay sudo codesign --deep -f -s - /System/Library/Frameworks/CoreDisplay.framework/Versions/Current/CoreDisplay

it works fine for me (macos ver. 10.12.6)

Bastani commented 6 years ago

Yeah coredisplayfixup + Lulu worked perfectly for me, I could upload the kexts I compiled if you like.

Floris497 commented 6 years ago

Precompiled kexts are available already on github I'll link to it :) it seems to be a more permanent fix for this problem :) I think everybody should move that way! I'll edit the readme with some links tomorrow

Bastani commented 6 years ago

Actually you'll need Lilu 1.2 and CoreDisplayFixup 1.3 which neither have been released yet. Everyone would have to compile it

Floris497 commented 6 years ago

Ah I wasn't aware.. you can post them :) and later we'll link somewhere permanent

Bastani commented 6 years ago

Here I have provided a link to my compiled versions of the Kexts: Lulu + CoreDisplayFixup

cmauribon commented 6 years ago

Hello, I'm sorry but i need help... I've an hd5500 with 4k screen, lilu and coredisplayfixup put in clover/kext/other, but my laptop reboot so fast i cannot see anything... I think i'm missing something... ( i have no trouble on sierra )

coolerhk commented 6 years ago

Thank you Bastani, your build is working fine on my 10.13, I use hd4600 on 2K monitor can output 2560*1440@60hz now.

spencerjason commented 6 years ago

Can someone explain how I use the Lulu + CDF kext files? My MacMini (2012) is sad on my LG UltraWide :/

spencerjason commented 6 years ago

Nevermind, I found the correct terminal procedure. Although I didn't seem to have a cache to remove, which seemed off (no such files existed). Reboot let me pick 2560x1080 @60hz with no issues.

Fingers crossed it holds up. Thanks @Bastani for the compiled link. đź‘Ť

LETRA commented 6 years ago

@spencerjason Please explain the entire process

Floris497 commented 6 years ago

Tonight when I'm home I'll rewrite the readme after some testing :)

HubertPluskota commented 6 years ago

@spencerjason Hey, can you give the command you used?

cmauribon commented 6 years ago

@spencerjason : how do you use lilu + CDF ? I can't get it work in clover, I also remove cache, without change, bootloop :( ( i use the lastest compiled version of lilu and cdf )

spencerjason commented 6 years ago

Not sure I know the exact steps to replicate, and I don't know anything about clover, however when I tried to install Pixel-Clockv2/3/4 it gave all kinds of errors when trying to patch. In the process, I lost the ability to cut-n-paste and my .bak was missing. So I bit the bullet, rebooted into recovery and reinstalled the OS (kept existing files, so not fresh install).

With that, I followed these directions for installing both Lilu and CDF .kext files.

NOTE: Whenever I tried to remove the kext caches I was told the files didn't exist. I rebooted anyway and when I went to the display dialogue, the new resolutions were already there. I still had to switch to it for it to use, but I've not had any issues in the last 24 hours that I've been running.

I'm sure that @Floris497 or @Bastani will be better on the technical side of describing it when they have time to update.

cmauribon commented 6 years ago

@spencerjason Lilu and CDF not working for me from a clean high sierra install... In verbose mode,it's boot normaly but when it go to load framebuffer there is a lot of text and It reboot so fast i cannot take a picture on what it going on

TylerD89 commented 6 years ago

@cmauribon Kernel panics don't really point out much info on what causes them. In fact, all it gives you is text that doesn't really make any sense. If you want to see it for yourself and you are using Clover, press space on the macOS boot option, scroll down with arrow keys and find "Don't Reboot on Panic" and press space on it, scroll back up to the top and press enter on "Boot macOS with selected boot options." If it continues to panic, replicate the same steps as above but instead select "Safe Mode". This will load macOS with only core drivers initialized. Then remove the kexts and it should be ok

cmauribon commented 6 years ago

There is a lot of display's error/bug with High sierra, maybe we should wait for a more stable version

juvenal commented 6 years ago

@cmauribon, the final version on macOS 10.13 (High Sierra) was released by Apple on September, 25th... I think Apple wouldn't release anything "more stable" to wait for...

cmauribon commented 6 years ago

@juvenal : I saw multiple user complaining with graphical issues with external display on macos 10.13.0

cmauribon commented 6 years ago

and apfs is really unstable ( on hackintosh ) : dirty reboot could result on a unreadable partition

Bastani commented 6 years ago

The issues you're having will likely not get fixed by apple as they have nothing to do with their end, it's just something the hackintosh community has to figure out how to fix. Also you do realize that It's not only people with a hackintosh that uses this patch right?

Floris497 commented 6 years ago

This thing was never meant for hackintosh actually, it came to be.. i think now the best way ti patch is with lilu, I've not tried it.. i have no compatible hardware running anymore.. so sorry for all.. it's getting mor difficult for me to maintain :/

Bastani commented 6 years ago

Yeah thank you for all your hard work @Floris497, It was good while it lasted, people here will just have to try and get it to work with Lilu, It seem to be the way forward. I am personally using it with a hackintosh and all I did was just drop Lilu and CoreDisplayFixup in the appropriate kext folder in clover. For people who aren't using a Hackintosh, I'm not sure. I assume you'll have to put them in System/Library/Extensions and run an appropriate kext utility to get them to work.

Floris497 commented 6 years ago

Exactly Lilu is the way to go now, it's a way more elegant way for this path :)

pedrohex commented 6 years ago

I dont have an hackintosh and i have some issues on external monitors. For instance apple mail when showing on second screen

screen shot 2017-10-09 at 21 29 56

Floris497 commented 6 years ago

That does not look good at al.. no idea how to fix it :/

pedrohex commented 6 years ago

@Floris497 , i didnt install the patch. This is a clean high sierra on a mbp 2011.

pedrohex commented 6 years ago

this means apple will be fixing some display issues next release.

Floris497 commented 6 years ago

You're quite confident that Apple will do that next release.. please make sure you file a bug report at apple.

pedrohex commented 6 years ago

well... i tried but i dont have a developer account so...

pedrohex commented 6 years ago

ops.. got it : https://www.apple.com/feedback/macbookpro.html

imguilherme commented 6 years ago

Some update ?

Floris497 commented 6 years ago

Not really.. no time.. look for lilu kext and so on :) should work

Floris497 commented 6 years ago

Whoops

juvenal commented 6 years ago

@Floris497, there is an update: 10.13.1 Although I didn't see any fix on CoreDisplay, or any fix related to graphics output, did you have time to play a little with possible fixes for this patch? I updated to 10.13 (now 10.13.1), because I develop for the macOS platform, and I have to test my software on 10.13... And the result is that it rendered my ultra wide monitor less useful...

Floris497 commented 6 years ago

I'm sorry but I have no time at all right now, maybe in 2 weeks...

TylerD89 commented 6 years ago

@juvenal Are you using a Hackintosh or real Mac? If you’re using a hackintosh, install Lilu.kext and CoreDisplayFixup.kext. It does the same thing but requires more work

Floris497 commented 6 years ago

Both hack and Mac should be able to use lilu I think :)

TylerD89 commented 6 years ago

Unfortunately not the case. CoreDisplayFixup needs to be injected into the firmware, it doesn’t work from /S/L/E

Floris497 commented 6 years ago

Oh really.. wasn't aware of that.. also i have no clue how it's working.. if @PMheart would like to explain it to me he can send me an email or something :)

TylerD89 commented 6 years ago

Yeah that’s beyond me. I have no idea how you people can code that stuff. I mean I know how to code, but I could never actually build something like that

juvenal commented 6 years ago

Hi @TylerD89, I'm using a Mac (two to be honest, one Mac mini late 2012 and a MacBook Pro late 2011). I updated the MacBook for High Sierra, but hold back the Mini with Sierra. @Floris497, I tried to look at the CoreDisplay disassembly, but it seems to be completely rewritten, as the symbols are all different and in different places in the text section. To better use my notebook with my desktop monitor, I'm looking for alternatives, like different kinds of connections between the machine and the monitor... Anything that your experience could help? Thanks for your time with this!

Floris497 commented 6 years ago

I've already found the function to patch, it's also in the script but not activated.. the problem.. it breaks copy/past in the whole OS...