Floris497 / mac-pixel-clock-patch-V2

994 stars 221 forks source link

Doesn't work on Majavi #280

Open buhlaze opened 6 years ago

buhlaze commented 6 years ago

Can we get a patch for Mojavi 10.14? I tried the current one and it does not work.

Floris497 commented 6 years ago

Just got it installed, will check it out later this week maybe next week, since I have some holidays now :)

Floris497 commented 6 years ago

Highly risky

not tested at al, did not even check if my Mac still boots.. but for the sake of it..

EDIT: New file.. CoreDisplay-patcher.command.zip

Floris497 commented 6 years ago

It does boot.. that's something.. only "SwitchResX" has a bug and can't make custom res.. so maybe it does work maybe it does not.. feel free to share if it worked or not :) (I'm still not responsible if you system doesn't boot after)

scottsanett commented 6 years ago

It doesn't seem to be working on my Hackintosh, i.e. unable to use 4K monitor with non-iris integrated graphics.

Floris497 commented 6 years ago

Did you make custom resolutions?

scottsanett commented 6 years ago

It's a newly installed Mojave beta so I don't think so.


Hmmm, I disassembled both the patched and unpatched CoreDisplay and it doesn't seem that there is any difference at all.

Floris497 commented 6 years ago

Oh.. well.. could have been i was tired.. didn't check uh... I'll try again

Floris497 commented 6 years ago

I made a small mistake with the copy paste, new file attached to the comment :) should patch and boot.. if it works.. idk

phamminhtris commented 6 years ago

Well, I have tested your new file. It does not seem to work.

golimpio commented 6 years ago

Have anyone managed to make it work with Mojave?

simnsdt commented 6 years ago

Any updates on this? Gonna try it myself soon on Mojave.

danieltroger commented 6 years ago

Tried it on mojave (10.14 Beta, Build 18A371a). Doesn't work. You forgot adding v5 to the list of commands at

    fi
    case "$2" in
      v1) CoreDisplayPatch 1;;
      v2) CoreDisplayPatch 2;;
      v3) CoreDisplayPatch 3;;
      v4) CoreDisplayPatch 4;;

But even after adding and rebooting it doesn't work. Btw, here's the beta version of SwitchResX that support Mojave, in case somebody is looking for it: https://www.madrau.com/SwitchResXb.zip

I'd love if you could do a patch, here's my version of CoreDisplay: https://mega.nz/#!ATRDBSZB!3gfsvTLVyVJaB0Qx2pSWwFHQqzIcy05V9xzqv_uN4ig

Floris497 commented 6 years ago

Not much active on the project lately, but I’ll try some stuff somewhere around this week :)

ihainan commented 6 years ago

@Floris497 Just curious if any progress has been made on this issue? :D

Floris497 commented 6 years ago

Not really.. turns out I have no hardware available anymore to test this on.. I have an 2011 MacMini.. but unfortunately it does not run Mojave.. my 2013 MacBook Air does not support 4k at all (some frame buffer problem.. I'll give that a look again actually) right now I'm going to test some stuff to see what I can get working.. but don't expect to much soon.. (a well maybe I have something today, who knows)

Floris497 commented 6 years ago

Uh.. it looks like the whole code is rewritten.. (maybe in swift.. I don't know enough about what the asm that swift produces looks like..) anyway.. I'm not here the next 2 days.. (just few hours today) if I don't get anything now.. it's gonna take some days.. anyone interested to break their system once I find something that MAYBE works? :D

danieltroger commented 6 years ago

Sure, I built a hackintosh with a 1080ti instead, so my 2012 macmini is unused. Also, don't I just have to restore the backuped CoreDisplay if it doesn't work?

Am 11.09.2018 um 15:58 schrieb Floris Fredrikze notifications@github.com:

Uh.. it looks like the whole code is rewritten.. (maybe in swift.. I don't know enough about what the asm that swift produces looks like..) anyway.. I'm not here the next 2 days.. (just few hours today) if I don't get anything now.. it's gonna take some days.. anyone interested to break their system once I find something that MAYBE works? :D

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Floris497 commented 6 years ago

Yes, if it does not work you can easily restore the old one. but just don't be scared of single user mode :) (I tried to patch 2 things.. both don't seem to work..)

Floris497 commented 6 years ago

Guys.. maybe I found something.. feel free to test it.. it does not crash my system, so it should be fairly safe.. but the big question.. does it work. please let me know what it does :) CoreDisplay-patcher.command.zip

gujiangjiang commented 6 years ago

@Floris497 WORKS!

qq20180916-000856 2x

You are so quickly to find the new patch and it works perfectly!

Thanks very much!

ro7in commented 6 years ago

@Floris497 WORKS!

qq20180916-000856 2x

You are so quickly to find the new patch and it works perfectly!

Thanks very much! I don't know about you, but mine still does not work.

screen shot 2018-09-15 at 1 53 02 pm
Floris497 commented 6 years ago

WHAT?!? It works??? Yusss! Oh I guess I cheered too early.. anyway I’m not home till tomorrow..

ro7in commented 6 years ago

I have no idea if it's really work on his machine, but it doesn't work on mine.

benbaker76 commented 6 years ago

I'm using WhateverGreen cdf patch and it appears to work fine for me in macOS (18A389)

CoreDisplay-patcher.command: Find: 4D 8B 36 4D 85 F6 0F 85 29 FD FF FF 31 DB EB 47 Replace: 4D 8B 36 48 85 C0 0F 84 29 FD FF FF 31 DB EB 47

WhateverGreen cdf: Find: BB 01 00 00 00 A8 01 0F 85 Replace: 31 DB 90 90 90 90 90 90 E9

Why are the two patches so different?

EDIT: I think gujiangjiang is also using WEG cdf patch so he probably just needed to reboot a few times for it to start working (I have to do this after an update).

gujiangjiang commented 6 years ago

@headkaze WEG -cdfon was no use on macOS 10.14 i have tested.

How you use WEG -cdfon to use cdfpatch?

-cdfon or enable-hdmi20?

Floris497 commented 6 years ago

Oh.. now I’m confused.. so the old patch is still working on hack? It isn’t on native mac... I kinda lost what is going on with it anyhow..

gujiangjiang commented 6 years ago

I use old patch with CDF or WEG are all not work and i dont know how to use it.

Floris497 commented 6 years ago

Right.. so there is nothing to do? I’m going to have a look at what is going om exactly tomorrow 🙃

gujiangjiang commented 6 years ago

now it works fine with your new patch. but WEG still with no use and i dont know what happend and i tried -cdfon and enable-hdmi20 but both with no use. Maybe it is Lilu related problem?

benbaker76 commented 6 years ago

@Floris497 check out WhateverGreen (CoreDisplayFixup) patches here.

Floris497 commented 6 years ago

@headkaze thank you, I’ll check it out :)

gujiangjiang commented 6 years ago

@headkaze @Floris497 BIG strange. I just replaced the CoreDisplay to the original with only [-cdfon] boot-args and it works...

But i have test one day more than 20 times but still cant boot yesterday and now it works with WEG.

strange...

Maybe it was the problem with 'updating' Maybe fresh install will not be this problem.

Thanks for you to help me with this strange problem and i wll give it more test and feedback later.

Thanks!

devianter commented 6 years ago

@headkaze thank you, I’ll check it out :)

Hey Floris and thanks for all your work! As soon as Mojave goes public (cant install beta on work machine) i'll test it on 2012 Air i hope it works as the 21:9 is a lifesaver for me!

walkerfirmin commented 6 years ago

I’m don’t have much experience with bash script or pearl script but I have a 4K hackintosh laptop “Asus Vivobook N552VW” which I have fully working on High Sierra and I have been playing with Mojave betas, but I have had no luck on tonymacx86 where they deleted my post on the topic, I guess beta talk is a deathly sin over on their blog. I have everything working except graphic acceleration at 4K resolution on Mojave. I am highly anticipating any updates on this patch for macOS 10.14 Mojave. Especially since it is up for release on the 24th of the month. I am playing around with the source code and trying to understand how it is implemented. Later this week after college work is done I will test the code above to see if it works. What are some helpful sources to look at until release of a working patch to learn how to do these patches my self?

benbaker76 commented 6 years ago

If you want to give the WhateverGreen (CoreDisplayFixup) patch a try using this script you can replace with the following lines (use at your own risk):

10.12.x and 10.13.0-10.13.3 sudo perl -i.bak -pe '$before = qr"\xB8\x01\x00\x00\x00\xF6\xC1\x01\x0F\x85"s;s/$before/\x33\xC0\x90\x90\x90\x90\x90\x90\x90\xE9/g' $CoreDisplayLocation

10.13.4+ sudo perl -i.bak -pe '$before = qr"\xBB\x01\x00\x00\x00\xA8\x01\x0F\x85"s;s/$before/\x31\xDB\x90\x90\x90\x90\x90\x90\xE9/g' $CoreDisplayLocation

walkerfirmin commented 6 years ago

I Installed Mojave and tried the script 10.13.4+ and got this message "-i used with no filenames on the command line, reading from STDIN." What am I expected to do?

devianter commented 6 years ago

I Installed Mojave and tried the script 10.13.4+ and got this message "-i used with no filenames on the command line, reading from STDIN." What am I expected to do?

did you install with -v5 ?

Floris497 commented 6 years ago

"$CoreDisplayLocation" is not file path :) better run this code by using v3/v4/v5 as described in README

devianter commented 6 years ago

"$CoreDisplayLocation" is not file path :) better run this code by using v3/v4/v5 as described in README

dear Floris did you have time to further test it on Mojave?

destrozeitor commented 6 years ago

Latest patch mot working on my system either. (10.14 directly upgraded from High Sierra) I have just installed Lilu and WhateverGreen in S/L/E with kext utility and voila! All resolutions working again (Intel HD4600) Your patch worked like a charm until now, Floris!. I am very grateful for your effort!

romulojabbour commented 6 years ago

Destrozeitor, how to do this?

tsl0922 commented 6 years ago

Update: Lilu + WhateverGreen still works for me on 10.14.1 18B75 (2560 x 1440 @ 60 Hz).

WhateverGreen (old patch) still works for me (10.14 18A391 HD4600), macOS Mojave disables subpixel antialiasing by default, this enables it (run and re-login):

defaults write -g CGFontRenderingFontSmoothingDisabled -bool NO
ModMike commented 6 years ago

Trying to get this to work. Not even SwitchResX works. I am running the release version, not beta. Do you need to add the MD5 checksum for Mojave release?

hoomanrow commented 6 years ago

"$CoreDisplayLocation" is not file path :) better run this code by using v3/v4/v5 as described in README

Which README file and which app are you referring to (for v3/v4/v5)? I'm having the same problem, swithresx worked fine but now I can't add my custom resolutions with the new macos mojave release.

juanhuerta commented 6 years ago

The problem with SwitchresX for me is that the custom resolution I used in High Sierra before upgrading to Mojave appears in the custom resolution list (that's ok), but with the message "Not Installed", and every time that I press the "Install immediatly" button it tries to switch but after a couple of "gray noise" screens it returns to the default resolution, and the message "Not installed" still shows.

-- Juan Carlos Huerta --

El mar., 25 de sep. de 2018 a la(s) 20:20, Hooman Rowshanbin ( notifications@github.com) escribió:

"$CoreDisplayLocation" is not file path :) better run this code by using v3/v4/v5 as described in README

Which README file and which app are you referring to (for v3/v4/v5)? I'm having the same problem, swithresx worked fine but now I can't add my custom resolutions with the new macos mojave release.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Floris497/mac-pixel-clock-patch-V2/issues/280#issuecomment-424552997, or mute the thread https://github.com/notifications/unsubscribe-auth/AG7d9FLlX0MhiL85IVqWZ818xXzXu9n1ks5uetZigaJpZM4Uag4b .

ModMike commented 6 years ago

That’s exactly what happens to me.

juanhuerta commented 6 years ago

BTW, I'm using a MBP 15" mid 2012 (no Retina)

-- Juan Carlos Huerta --

El mar., 25 de sep. de 2018 a la(s) 20:42, Michael Triffon ( notifications@github.com) escribió:

That’s exactly what happens to me.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Floris497/mac-pixel-clock-patch-V2/issues/280#issuecomment-424556504, or mute the thread https://github.com/notifications/unsubscribe-auth/AG7d9KPGLDGkzQdCrhbOE7weHnEXmb6lks5uetuWgaJpZM4Uag4b .

hoomanrow commented 6 years ago

That's what I get too, mac mini late 2012 with an LG 2560x1080 monitor @50hz

juanhuerta commented 6 years ago

Just to let you know, I was using an unregistered version of switchresx, with no more trial period, because of that I can't install or save new config. I just registered my copy for $16 USD, and now everything works in my MBP mid 2012, Mojave and LG Ultrawide 34".

-- Juan Carlos Huerta --

El mar., 25 de sep. de 2018 a la(s) 21:31, Hooman Rowshanbin ( notifications@github.com) escribió:

That's what I get too, mac mini late 2012 with an LG 2560x1080 monitor @50hz https://github.com/50hz

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Floris497/mac-pixel-clock-patch-V2/issues/280#issuecomment-424564155, or mute the thread https://github.com/notifications/unsubscribe-auth/AG7d9CnwkEuwNjXdoT3HBU6kH8LNXr4Nks5ueucPgaJpZM4Uag4b .

ModMike commented 6 years ago

Same here. Had to create a new user, log in, install switchresx, create custom profile, then I copied the contents folder from the displays folder into my old account to flush out all the crap I put in. Works a treat now.