search

Flotype / now

NowJS makes it easy to build real-time web apps using JavaScript
http://www.nowjs.com
MIT License
1.91k stars 175 forks source link

Disconnect handler triggers a JS error in IE8 #103

Closed AD7six closed 13 years ago

AD7six commented 13 years ago

As can be seen here: IE8 being beautiful as usual

The disconnect handler code triggers an error in IE8. Not sure of a correct fix, so none suggested at this time.

tommedema commented 13 years ago

should this not be typeof(obj[i]) === 'object' ?

ericz commented 13 years ago

typeof also works without the parenthesis (in IE as well as other browsers). The issue I believe is that seen appears to be an object and not an array -- as seen in the "locals" panel on the right side of the screenshot, which would make .indexOf throw the exception

AD7six commented 13 years ago

that pesky comment & close button ... :)

ericz commented 13 years ago

Haha yepp

steveWang commented 13 years ago

The issue here is really that IE 8 doesn't define Array.indexOf. Presumably commit 4bcd30668ff97179257703d030c1aad221516745 fixed this.

AD7six commented 13 years ago

Presuming is no substitute for testing :)

While the specific error reported in the ticket is nolonger generated, it's simply replaced with "Error: Out of memory"

Since I can't reopen the ticket I trust someone on the team will.

steveWang commented 13 years ago

More specifics would be nice. And it's a bit difficult to test IE without Windows, but it's a bit difficult to develop with Windows. ;D

AD7six commented 13 years ago

I know - every time I open my VM I feel a part of me dies. Then I open IE and a bit more of me follows.

I don't have anything more specific to add; I could do another screenshot but all it would show is the text "Error: Out of memory" in the console of developer tools.

The most detailed I can be is: In IE on the master branch (with that one commit cherry-picked) if the node server is killed/restarted the text "Error: Out of memory" (alone, no file reference) is printed to the console. and it's 100% reproducible.

ericz commented 13 years ago

Hey AD7six, I'll look into this today.

Thanks for staying diligent. Definitely appreciate it.

steveWang commented 13 years ago

Wow, I feel stupid. Fixed in 4766fe501d8d43b99a56d241f1631f422094d684.