Flotype / now

NowJS makes it easy to build real-time web apps using JavaScript
http://www.nowjs.com
MIT License
1.91k stars 175 forks source link

Client disconnect? #24

Closed j03m closed 13 years ago

j03m commented 13 years ago

Hey, I unfortunately don't have a great deal of replication information around this but I did grab the stack trace from Node. I was running the chat demo (which is awesome) and I noticed every once in a while one of the clients would disconnect. It would continue to publish updates, but not receive them (which I found odd). It did occur at the same time as this stack trace:

{ stack: [Getter/Setter], arguments: [ 'hasOwnProperty', undefined ], type: 'non_object_property_call', message: [Getter/Setter] } TypeError: Cannot call method 'hasOwnProperty' of undefined at Object.getVarFromFqn (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowUtil.js:86:18) at Object.remoteCall (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:55:31) at [object Object]. (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:273:48) at [object Object].emit (events.js:64:17) at [object Object]._onMessage (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/client.js:58:10) at Parser. (native) at Parser.emit (events.js:64:17) at Parser.parse (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:195:12) at Parser.add (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:182:8) at Socket. (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:116:17) { stack: [Getter/Setter], arguments: [ 'hasOwnProperty', undefined ], type: 'non_object_property_call', message: [Getter/Setter] } TypeError: Cannot call method 'hasOwnProperty' of undefined at Object.getVarFromFqn (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowUtil.js:86:18) at Object.remoteCall (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:55:31) at [object Object]. (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:273:48) at [object Object].emit (events.js:64:17) at [object Object]._onMessage (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/client.js:58:10) at Parser. (native) at Parser.emit (events.js:64:17) at Parser.parse (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:195:12) at Parser.add (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:182:8) at Socket. (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:116:17) { stack: [Getter/Setter], arguments: [ 'hasOwnProperty', undefined ], type: 'non_object_property_call', message: [Getter/Setter] } TypeError: Cannot call method 'hasOwnProperty' of undefined at Object.getVarFromFqn (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowUtil.js:86:18) at Object.remoteCall (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:55:31) at [object Object]. (/usr/local/lib/node/.npm/now/0.3.1/package/lib/nowServerLib.js:273:48) at [object Object].emit (events.js:64:17) at [object Object]._onMessage (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/client.js:58:10) at Parser. (native) at Parser.emit (events.js:64:17) at Parser.parse (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:195:12) at Parser.add (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:182:8) at Socket. (/usr/local/lib/node/.npm/socket.io/0.6.16/package/lib/socket.io/transports/websocket.js:116:17)

ericz commented 13 years ago

Hmm I will look into this.

Thanks for the report!

j03m commented 13 years ago

Not sure if it's related but a new version of Socket.IO came out today, might possibly help. I will give it a whirl when I get home.

On Wed, Mar 30, 2011 at 3:12 PM, ericz < reply@reply.github.com>wrote:

Hmm I will look into this.

Thanks for the report!

Reply to this email directly or view it on GitHub: https://github.com/Flotype/now/issues/24#comment_937791

ericz commented 13 years ago

Based on the stack trace, this looks like an issue with improper disconnections, specifically when the client times out or otherwise disconnections ungracefully. We'll be fixing this in the next version of now.

ericz commented 13 years ago

Closing

j03m commented 13 years ago

Awesome, will give it a spin.

On Fri, Apr 1, 2011 at 1:45 PM, ericz < reply@reply.github.com>wrote:

Closing

Reply to this email directly or view it on GitHub: https://github.com/Flotype/now/issues/24#comment_946392