search

Flow-Community / Community.News

Node-based news extension for Neos CMS
15 stars 6 forks source link

BUGFIX: adjust cache config to make pagination work #17

Closed mkuiphuis closed 8 years ago

mkuiphuis commented 8 years ago

As discussed with Dmitry on Slack... the proposed changes make page navigation work again

dimaip commented 8 years ago

Hey, thanks for taking care! I think it would be better if you move this part to root.ts2:

prototype(TYPO3.Neos:ContentCollection).@cache.entryIdentifier.pagination = ${request.pluginArguments.listable-paginate.currentPage}
prototype(TYPO3.Neos:Page).@cache.entryIdentifier.pagination = ${request.pluginArguments.listable-paginate.currentPage}
root.@cache.entryIdentifier.pagination = ${request.pluginArguments.listable-paginate.currentPage}
dimaip commented 8 years ago

Hey but I still don't see the changes to root.ts2...

mkuiphuis commented 8 years ago

I thought you meant the Root.ts2 in my own site package and not the Root.ts2 of the news package. I'll probably close this pull request and start a new one....

dimaip commented 8 years ago

Oh no no, I totally makes sense to put it into the package, it belongs there, just in the root.ts2, to make it more visible

dimaip commented 8 years ago

Perfect, thanks!