search

Flow-Launcher / Flow.Launcher.Plugin.Everything

This is the Everything plugin for Flow Launcher.
50 stars 9 forks source link

Opening Files With Custom Editor Still Not Working When Spaces In Path #27

Closed robertoleonardo closed 3 years ago

robertoleonardo commented 3 years ago

hi - i see several updates ostensibly addressing an issue opening files when their paths have spaces - i'm on the current version of the plugin adn the current flow launcher, and i'm still not able to open files with custom editor.

Custom editor path: "C:\Program Files\IDM Computer Solutions\UltraEdit\uedit64.exe" Settings:
image

Error:
image

Works fine when no spaces in path. If you look at the error - it looks like it's using the app folder as the working folder and then merging with the actual file path after the first space (the full path of the file i was trying to open was: D:\Dropbox\Documents\Backups and Maintenance\Automation\Batch Files\Settings Backups - Cleanup.bat)

Can't put my finger on what makes the difference - but i've noticed sometimes it uses the windows directory as the working folder - but gives me basically the same error except instead of starting with flow's appdata folder, the first half of the path in the error message is c:\windows\system32.

also, sometimes ultraedit tries to open a separate file for each space in the path.

taooceros commented 3 years ago

Hi, sorry for the late reply, would you please share the arg you are using for customized explorer?

robertoleonardo commented 3 years ago

D:\Dropbox\Documents\Backups and Maintenance\Portable Executables\XYPlorer (Portable)\XYplorer.exe params: /win=max

taooceros commented 3 years ago

I guess you may need to add %s to the end of the args?

robertoleonardo commented 3 years ago

Why are we talking about custom explorer? just to make sure we're on the same page: my issue is with the custom editor

From: Kevin Zhang @.> Sent: Monday, April 5, 2021 1:30:55 AM To: Flow-Launcher/Flow.Launcher.Plugin.Everything @.> Cc: robertoleonardo @.>; Author @.> Subject: Re: [Flow-Launcher/Flow.Launcher.Plugin.Everything] Opening Files With Custom Editor Still Not Working When Spaces In Path (#27)

I guess you may need to add %s to the end of the args?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27#issuecomment-813273258, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADELGE4DPFIEV5EZBYT4WXLTHFYL7ANCNFSM4ZFSNKRQ.

taooceros commented 3 years ago

Why are we talking about custom explorer? just to make sure we're on the same page: my issue is with the custom editor … ____ From: Kevin Zhang @.> Sent: Monday, April 5, 2021 1:30:55 AM To: Flow-Launcher/Flow.Launcher.Plugin.Everything @.> Cc: robertoleonardo @.>; Author @.> Subject: Re: [Flow-Launcher/Flow.Launcher.Plugin.Everything] Opening Files With Custom Editor Still Not Working When Spaces In Path (#27) I guess you may need to add %s to the end of the args? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#27 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADELGE4DPFIEV5EZBYT4WXLTHFYL7ANCNFSM4ZFSNKRQ.

Oh sorry, I misunderstood your issue. Let me check whether we should add a "" for custom editor.

robertoleonardo commented 3 years ago

Ha no worries, just wanted to make sure! glad I did.

And yea, it definitely seems like the issue relates to “

Thanks kevin!

From: Kevin Zhang @.> Sent: Monday, April 5, 2021 1:54 AM To: Flow-Launcher/Flow.Launcher.Plugin.Everything @.> Cc: robertoleonardo @.>; Author @.> Subject: Re: [Flow-Launcher/Flow.Launcher.Plugin.Everything] Opening Files With Custom Editor Still Not Working When Spaces In Path (#27)

Why are we talking about custom explorer? just to make sure we're on the same page: my issue is with the custom editor … ____ From: Kevin Zhang @.> Sent: Monday, April 5, 2021 1:30:55 AM To: Flow-Launcher/Flow.Launcher.Plugin.Everything @.> Cc: robertoleonardo @.>; Author @.> Subject: Re: [Flow-Launcher/Flow.Launcher.Plugin.Everything] Opening Files With Custom Editor Still Not Working When Spaces In Path (#27 https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27 ) I guess you may need to add %s to the end of the args? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#27 (comment) https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27#issuecomment-813273258 >, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADELGE4DPFIEV5EZBYT4WXLTHFYL7ANCNFSM4ZFSNKRQ.

Oh sorry, I misunderstood your issue. Let me check whether we should add a "" for custom editor.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27#issuecomment-813283819 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELGE6I34PMM7JISMSZVBDTHF3EDANCNFSM4ZFSNKRQ . https://github.com/notifications/beacon/ADELGE274BX6XCH5N2W6IVLTHF3EDA5CNFSM4ZFSNKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGB43T2Y.gif

taooceros commented 3 years ago

Hi I just got time to take a look on the code, but it seems that we do have added a "" surrounded the path. Give me sometimes to investigate it more since I am busy this week.

robertoleonardo commented 3 years ago

Thanks – take your time

From: Kevin Zhang @.> Sent: Tuesday, April 6, 2021 7:57 PM To: Flow-Launcher/Flow.Launcher.Plugin.Everything @.> Cc: robertoleonardo @.>; Author @.> Subject: Re: [Flow-Launcher/Flow.Launcher.Plugin.Everything] Opening Files With Custom Editor Still Not Working When Spaces In Path (#27)

Hi I just got time to take a look on the code, but it seems that we do have added a "" surrounded the path. Give me sometimes to investigate it more since I am busy this week.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27#issuecomment-814564110 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADELGE33OUXG5LLK4TOXUC3THPCYTANCNFSM4ZFSNKRQ . https://github.com/notifications/beacon/ADELGEZCRU3IEU3FOYITHTDTHPCYTA5CNFSM4ZFSNKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGCGUGDQ.gif

taooceros commented 3 years ago

@robertoleonardo I probably find the issue.

Sorry for the late reply😖. It may because we have added too much "" around the argument.

I add the fix in #29, you can take a try if you want.

robertoleonardo commented 3 years ago

yessss! the #29 fix works! thank youu!!!

taooceros commented 3 years ago

Nice to hear that! 😉

robertoleonardo commented 3 years ago

ohhh and i'm digging the new 'sort by' option too....

-- rob lee

On Wed, Jul 21, 2021 at 10:46pm, Kevin Zhang < @. @. > wrote:

Nice to hear that! 😉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/27#issuecomment-884669501] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/ADELGE4VOL646P6543GXMCLTY6WC5ANCNFSM4ZFSNKRQ] .