Fix incorrect error reporting from Fast Sort check

[jjw24]

• Fix incorrect error reporting from Fast Sort check, which reports service not running error as fast sort option not enabled.
• Updated Fast Sort option not supported message
• Switch the non-Fast Sort search restriction to plugin setting warning
• Show Everything service not running in settings

close https://github.com/Flow-Launcher/Flow.Launcher.Plugin.Everything/issues/34

[jjw24]

@taooceros I have not been successful in disabling fast sort option to check this condition:

Turning off all these still get the Fast Sort option as true . Any ideas?

[taooceros]

I do notice this error for quite a while, but forget to fix it before😯

[taooceros]

Name is fast sort by default.

[taooceros]

Probably you may need a rebuild index before seeing the effect of fast sort (because it is basically an index i guess)

[jjw24]

Name is fast sort by default.

hmm which one is not do you know?

[taooceros]

Hmm I think if there's an option, it shouldn't be fast sort by default.

[jjw24]

Hmm I think if there's an option, it shouldn't be fast sort by default.

sorry what do you mean?

[taooceros]

And there are a few that seems cannot be fast sort (filelist I guess).

[taooceros]

Hmm I think if there's an option, it shouldn't be fast sort by default.

Oh as I remember, only name is fast sort by default. I mean the option to enable fast sort in the previous image.

[jjw24]

I have switched them off and still not getting the error lol

[taooceros]

Try force rebuild?

[taooceros]

Have you changed the sort option in Flow? The default sort option in Flow is name, which is always fast sort.

[jjw24]

Have you changed the sort option in Flow? The default sort option in Flow is name, which is always fast sort.

that's it lol, i did not notice the option in flow, rather was trying with Everything's own settings, and yep File List FileName sort option is not fast sort.

I will change the error message.

[jjw24]

should we remove File List FileName sort option from being set in flow's settings if we dont allow it?

[jjw24]

For prosperity, these are the non-Fast Sort options in Everything:

• File List FileName sort option
• Path
• Size
• Type Name

[jjw24]

@taooceros i tried a couple of the non-Fast Sort options, seems to work ok, obviously depends on the number of results the user gets, but do we want to allow those options and just put the warning in the settings page next to the sort drop down options?

[taooceros]

Sorry I didn't respond early because I miss the message.

@taooceros i tried a couple of the non-Fast Sort options, seems to work ok, obviously depends on the number of results the user gets, but do we want to allow those options and just put the warning in the settings page next to the sort drop down options?

Yeah we can, but Flow seems currently don't support FileList, so maybe remove that for now?

[taooceros]

@jjw24 Size is one of the fast sort option, same as Path. FileList FileName may not exist without extra setting, so I think we can remove it for now unless user want it.

From my testing, Type Name is not much slower than other FastSort (probably extension is indexed, so even its fastsort option is not enabled, it is not slow).

[jjw24]

So sounds like if we remove File list Filename sort then we can remove that restriction then? No need for any warning

[taooceros]

So sounds like if we remove File list Filename sort then we can remove that restriction then? No need for any warning

Hm not sure whether I understand here idea clearly. I add restrictions because everything include every files in the disk, so enable sorting without index will take almost forever. It is not quite possible to use non fastsort in Flow. Most fastsort is not enabled by default in everything, so a warning for user is required I think. The Filelist Filename has nothing to do with this, but just I am not quite sure how to use it though. 😂

[jjw24]

Oh ok, so we remove FileList Filename and add the warning to plugin's settings and allow them to use any options then?

Basically that method that checks if the sort option is fast sort, I will move it out of the main search method and just display a warning base on the fast sort check result

[taooceros]

Have you checked what will happen without fast search? In my computer, using not fast search will cause a huge cpu usage and computer slow down, and results will not be returned unless wait for a long time.

[jjw24]

So I tried a couple of them before (earlier comment), seems fine on my computer. Which non-fast sort option is causing the slow down for u can u list them please.

[taooceros]

Would you please take a try on attributes and deselect the option of indexing attribute, and force rebuild?

[jjw24]

so i tested those non-fast sort options and the result for me as i dont have a numerous amount of files to search through, using these options are fine. I did these steps:

commented out the code that throws the warning

1. deselect all these fast options

2. change sort to the non-fast option

3. force index rebuild

4. Change the settings in Flow's Everything plugin to match

5 repeat above for the other options

[jjw24]

since it seems ok with a smaller number of results, do we want to move the warning to the Plugin's settings Sort By option so users can still use them, or remove those non-fast sort option from being able to be selected in flow so we dont need to display the warning message. What do you think @taooceros ?

[taooceros]

Yeah if that works, we can do that. Probably because my computer got too much files so it stop responding for a long time when non fast sort.