search

Flow-Launcher / Flow.Launcher

:mag: Quick file search & app launcher for Windows with community-made plugins
https://flowlauncher.com
MIT License
7.76k stars 303 forks source link

Should the JsonRPC/wox.py stay with the main solution #158

Closed jjw24 closed 3 years ago

jjw24 commented 4 years ago

From https://github.com/jjw24/Wox/issues/196

image

Wox.Plugin.Timestamp.

jjw24 commented 4 years ago

I dont think it's a good idea to put it in a plugin. We need it to be a common library so it can be referenced and developed rather than each python plugin has its own version of it.

Zeroto521 commented 4 years ago

@jjw24 I agree. Build wox.py as a package. That's why I issued this problem.

Zeroto521 commented 4 years ago

I'm not a C# developer, so I don't know how useful the wox.py is. But as a Python developer, I think it's no use in Wox. And it has trouble with Python developer. In my option, using Json RPC just likes to exchange data information. C# gets data by python.exe running wox.py. And the JsonRPC is the data. Therefore, wox.py can be anywhere. If the plugin is the subclass of Wox. ¯\_(ツ)_/¯

jjw24 commented 4 years ago

I'm not a C# developer, so I don't know how useful the wox.py is. But as a Python developer, I think it's no use in Wox. And it has trouble with Python developer. In my option, using Json RPC just likes to exchange data information. C# gets data by python.exe running wox.py. And the JsonRPC is the data. Therefore, wox.py can be anywhere. If the plugin is the subclass of Wox. ¯\_(ツ)_/¯

From your points I think it makes sense to bring it out as a separate one. I have not had the chance to play around with it yet as I am working on another part of Flow. Flow's non-c sharp areas need a uplift for sure. If you like you can let me know or create your own repo show how best wox.py should be developed. Otherwise I will circle back to this any way once I am done as it's next on my plate.

Good discussions.

Zeroto521 commented 4 years ago

May be you @jjw24 should create an empty project called JsonRPC or else name in Flow-Launcher organization. I can finish it as a total Python package. When we check it already, we can upload it to PyPI.

jjw24 commented 4 years ago

May be you @jjw24 should create an empty project called JsonRPC or else name in Flow-Launcher organization. I can finish it as a total Python package. When we check it already, we can upload it to PyPI.

Sure thing.

I can do with some help in the Python development, would you like to be part of the team?

jjw24 commented 4 years ago

Created here https://github.com/Flow-Launcher/Flow.Launcher.JsonRPC.Python. We can rename the repo later on if need be

Zeroto521 commented 4 years ago

May be you @jjw24 should create an empty project called JsonRPC or else name in Flow-Launcher organization. I can finish it as a total Python package. When we check it already, we can upload it to PyPI.

Sure thing.

I can do with some help in the Python development, would you like to be part of the team?

That's my pleasure.

jjw24 commented 4 years ago

I have sent you an invite to the team

Zeroto521 commented 4 years ago

I got it, 🤝.