Flow-Launcher / Flow.Launcher

:mag: Quick file search & app launcher for Windows with community-made plugins
https://flowlauncher.com
MIT License
7.34k stars 297 forks source link

"Tab" for next item in search results #2151

Closed MaxHasBeenUsed closed 1 year ago

MaxHasBeenUsed commented 1 year ago

Is your feature request related to a problem? Please describe.

Can only go through items by arrow keys

Describe the solution you'd like

Press "Tab" key for next item, "Shift + Tab" for previous. Like in PowerToys Run and Listary

JohnTheGr8 commented 1 year ago

Hey, thank you for your feedback.

I suppose that what you want is to be able to navigate items with just your left hand on the keyboard.

The problem is, Flow already uses Tab as a mechanism for auto-completion. I'm afraid this doesn't leave any reasonable left-hand keys to use for the functionality you want... 🤷‍♂️

Garulf commented 1 year ago

We chose tab to mimic behavior found in console shells like BASH, ZSH, and Powershell.

Perhaps we could look into allowing this key to be customized?

JohnTheGr8 commented 1 year ago

imo complicating things by making this customizable would not be justified here...

(if your right hand is not on the keyboard, it's probably on the mouse, and you can use that to navigate)

MaxHasBeenUsed commented 1 year ago

Thanks for your quick responses!

We chose tab to mimic behavior found in console shells like BASH, ZSH, and Powershell. Perhaps we could look into allowing this key to be customized?

I use those tools as well, and see complete sense in "tab for auto complete". But for me it would be nice to have the option to make it work otherwise, since I basically use Flow as a launcher and barely need a auto complete feature. Also if I'm not wrong, "tab for navigation" is the default behavior in Listary and PowerToys Run. It would be easier for switching.

imo complicating things by making this customizable would not be justified here...

It could be confusing but Flow already allows people to change "Preview Hotkey" (similar to "Navigation Hotkey" or "Tab Key Behavior") and "Open Result Modifier Key" (also a great feature). Maybe a third one wouldn't hurt?

Btw I'm actually a right-handed. But from the time I added Microsoft Japanese IME (which uses tab to navigate) for language learning purposes, it just makes so much sense to me that I just can't go back.

VictoriousRaptor commented 1 year ago

It could be confusing but Flow already allows people to change "Preview Hotkey" (similar to "Navigation Hotkey" or "Tab Key Behavior") and "Open Result Modifier Key" (also a great feature). Maybe a third one wouldn't hurt?

I think "Tab Key Behavior" is the right way if we decide to implement such a feature. We barely have no keys for a new hotkey.

(if your right hand is not on the keyboard, it's probably on the mouse, and you can use that to navigate)

We still need to move right hand to touch arrow keys for navigation. Though open result modifier is surely better for instantly activating results.

JamesNZL commented 1 year ago

Transferring my comment from #2182—

I second this idea; I seem to find myself wishing for this ability every couple days.

Have we thought about using Alt + Tab as the hotkey (it is possible to intercept this while Flow is open?)

I'd argue that a launcher isn't really an application that you Alt + Tab away from in the traditional sense (and the launcher just closes itself anyway), so I think that intercepting the Windows hotkey probably isn't a UX problem.

jjw24 commented 1 year ago

From what I have read in issue 2182 and here, seems those that request for tab to go next result don't need the autocomplete feature. Perhaps VictoriousRaptor's idea for a "Tab Key Behaviour" is a good choice- customise it to allow the switch between either tab next or autocomplete.

Although, let's say once you have tabbed to go to the result you want, what's the hand action to activate the result? Use right hand to press enter or use left hand to press open result modifier?

I am also still on the fence about the benefits of tab to go next as you still end up using your right hand, awkwardly moving to the right with your left or work your fingers for the modifier key presses.

JamesNZL commented 1 year ago

seems those that request for tab to go next result don't need the autocomplete feature

Not true for me; I'd want to keep Tab for autocomplete, and have some other way to cycle through the results.

Although, let's say once you have tabbed to go to the result you want, what's the hand action to activate the result? Use right hand to press enter or use left hand to press open result modifier?

This is only if autocomplete isn't the desired action. Take the following example:

  1. I type tgl for the default hotkeys.

    image

  2. I want to cycle through the results to reports, which I currently have to use the arrow keys for. This cycles through the results, without auto-filling the query.

    image

  3. Once I have highlighted reports, I hit Tab to autocomplete tgl reports, which moves to the next plugin state.

    image

This repeats, all the way to the end state of tgl reports week projects, with only Tab autocompletes and no Enters. image

jjw24 commented 1 year ago

Going to convert this to discussion until we can come up with a good solution.