Flow-Launcher / Flow.Launcher

:mag: Quick file search & app launcher for Windows with community-made plugins
https://flowlauncher.com
MIT License
8.05k stars 314 forks source link

BUG: About thumbnails #2551

Closed 1208nn closed 6 months ago

1208nn commented 8 months ago

Checks

Problem Description

To Reproduce

I don't know the exactly conditions of triggering it, but I can provide some characteristics.

apologize for my poor English



sometimes when flow was still starting, I pressed alt+space and it will happens but in this occasions, once I kill and start manually, it works well and won't crashes frequently until a thumbnail error

Screenshots

below

Flow Launcher Version

at least from 1.9.0 to 1.17.1

Windows Build Number

at least from 10.1803 to 10.23H2

Error Log

```shell ----hide manually time---- - ERROR - ImageLoader.Load - Failed to get thumbnail for ----hide manually my flow dir----\FlowLauncher\app-1.17.1\Images\up.png on first try ---- added manually ---- this also has other pngs and more than 1 try EXCEPTION OCCURS: System.Runtime.InteropServices.COMException (0x80004005): Error while extracting thumbnail for ----hide manually my flow dir----\FlowLauncher\app-1.17.1\Images\up.png ---> System.Runtime.InteropServices.COMException (0x8004B201): 0x8004B201 at IntPtr Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 129 at BitmapSource Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 120 at ImageResult Flow.Launcher.Infrastructure.Image.ImageLoader.GetThumbnailResult(ref string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 247 at async ValueTask Flow.Launcher.Infrastructure.Image.ImageLoader.LoadInternalAsync(string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 169 ```
1208nn commented 8 months ago

thumbnails not only don't show in the result, also not show in settings, but sometimes when it not show, flow won't crashes.

Screenshots

setting window - plugins ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/b498e762-2340-47a1-a583-e91b226b2d12) search box ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/6d1446d6-fc69-402f-9731-aebeb6175e48) ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/24f7a135-a235-4251-aa1f-8ba90d3a5b6f) theme switcher preview (background) ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/3c0ef38a-85ec-4c70-8910-190919775e57) store (maybe caused by network, suggest a loading icon to recognize) ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/d7cfe730-c03f-4e58-9e90-ec4b13f4e446) no response ![image](https://github.com/Flow-Launcher/Flow.Launcher/assets/74806550/e82c5651-7a3b-47a5-8f06-f1157893bad9)
taooceros commented 8 months ago

Does it happens before?

1208nn commented 8 months ago

Yes

Flow Launcher Version

at least from 1.9.0 to 1.17.1

I started use Flow from 1.9.0.

Before I use Flow, I use Wox. It seldom crashes. I sometimes use PowerToys Run, It seldom crashes, too.

In the latest 1.17.1, sometimes the crash will directly cause the process killed, without the no response statues.

mlazzarotto commented 8 months ago

Same here, with FlowLauncher v1.17.2 and Windows 11 23H2

09:57:53.2882+01:00 - ERROR - ImageLoader.Load - Failed to get thumbnail for C:\Users\user\AppData\Local\FlowLauncher\app-1.17.2\Plugins\Flow.Launcher.Plugin.WebSearch\Images\web_search.png on second try
EXCEPTION OCCURS: System.Runtime.InteropServices.COMException (0x80004005): Error while extracting thumbnail for C:\Users\user\AppData\Local\FlowLauncher\app-1.17.2\Plugins\Flow.Launcher.Plugin.WebSearch\Images\web_search.png
 ---> System.Runtime.InteropServices.COMException (0x8004B201): 0x8004B201
   at IntPtr Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 129
   at BitmapSource Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 120
   at ImageResult Flow.Launcher.Infrastructure.Image.ImageLoader.GetThumbnailResult(ref string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 247
   at async ValueTask<ImageResult> Flow.Launcher.Infrastructure.Image.ImageLoader.LoadInternalAsync(string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 169
github-actions[bot] commented 6 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh

github-actions[bot] commented 6 months ago

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.