Flow-Launcher / Flow.Launcher

:mag: Quick file search & app launcher for Windows with community-made plugins
https://flowlauncher.com
MIT License
8.1k stars 316 forks source link

BUG: Explorer plugin with Everything index does not honor MaxResult setting #2873

Closed Ishmaeel closed 2 months ago

Ishmaeel commented 3 months ago

Checks

Problem Description

Results from Explorer plugin are limited to the hardcoded MaxResult (MaxCount) of 100 while using Everything engine. Changing the value in Settings.json has no effect.

Direct Enumeration and Windows Index are unaffected.

To Reproduce

  1. Disable all other plugins.
  2. Edit Flow.Launcher.Plugin.Explorer\Settings.json.
  3. Change MaxResult to 5.
  4. Ensure that Everything engine is enabled and Everything itself is running.
  5. Perform a query.

Expected result would be a list of 5 hits but the actual results will have up to 100 results.

  1. Switch from Everything engine to Windows Index engine.
  2. Perform same query.

Search results will be capped at 5 items as expected.

Screenshots

No response

Flow Launcher Version

1.18.0

Windows Build Number

Microsoft Windows [Version 10.0.19045.4651]

Error Log

No error log associated with the issue. MaxResult setting is simply not passed to Everything API.

Ishmaeel commented 3 months ago

Why is this an issue? I have some shortcuts I find via Explorer plugin and I'm used to typing a three-letter query to find these. However, when I type the query, the shortcut I'm interested in will be excluded from the results entirely, so I will be unable to launch it and bump its score for that query.

I thought about finding the same shortcut using a longer query and trying to bump its score that way, but since it will never be returned from the original Everything search, its score will always remain irrelevant. Flow will never be able to find that item even if its score is bumped through the roof.

Since Everything index contains, well, everything, a limit of 100 is way too restrictive. I would want to set it as high as I could without crippling performance so it would have a chance to include the things I'll be searching for.