Closed skjerns closed 3 years ago
This is on progress. Check out #78.
great! thanks!
No need to close. Should close when that pr has merged. Thank you for pointing out the need!
@skjerns This issue should be fixed, but 1.8.0 may not get released for a while, you can download the build here to use it https://ci.appveyor.com/api/buildjobs/8k1g0edbeqxlbqwk/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.1.exe
thanks! I'll try it out!
edit: seems to work
What is still missing is automatic indexing of C:\ProgramData\Microsoft\Windows\Start Menu
- could that be added? Quite a few programs are using this as the default, and some programs from there don't show up.
Weird I remember that's included. Have you selected the option to index start menu?
I just saw: It is included, however, there is a program missing that should be there: NeuroBS Presentation
It is showing up in the start menu, but not in wox
these are my settings:
I just saw: It is included, however, there is a program missing that should be there:
NeuroBS Presentation
It is showing up in the start menu, but not in wox
these are my settings:
I will take a look soon. AFKing now. Maybe there are multiple lnk pointing to the same exe but both of them doesn't contain descriptions so none of them are kept. This may be a logic issue on hashing. Thank you for pointing that out!
thanks! by the way, this is the link
However, there is something strange on the second tab:
this is the content of the lnk
which looks quite different from others I examinde
L � F�P � P�O� �:i�� +00� /C:\ V 1 mQ
L Windows @ ヌOwHzQ b. � �
W i n d o w s \ 1 zQ#b Installer D ヌO�IzQ#b. � �� I n s t a l l e r � 1 zQ#b {A43A9~1 ~ �zQ#bzQ#b. V� 0 d� { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } n 2 h zQ#b! ICON1D~2.EXE R �zQ#bzQ#b. � ��� I c o n 1 D 3 9 4 6 A 1 . e x e R . . \ . . \ . . \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e L C : \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e �FtVk]AMMz8SvzUNO`B%{>EQ=o1zSsp9ZlEKlJ[EbE F t V k ] A M M z 8 S v z U N O ` B % { > E Q = o 1 z S s p 9 Z l E K l J [ E b E �%SystemRoot%\Installer\{A43A9851-8770-4135-B469-EA77C02E38FF}\Icon1D3946A1.exe % S y s t e m R o o t % \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e
thanks! by the way, this is the link
However, there is something strange on the second tab:
this is the content of the
lnk
which looks quite different from others I examindeL ��� � F�P � � ��� �P�O� �:i���� +00�� /C:\ V 1 mQ L� Windows @ � ヌOwHzQ b. �� � � �W i n d o w s � \ 1 zQ#b� Installer D � ヌO�IzQ#b. �� � ��� I n s t a l l e r � � 1 zQ#b� {A43A9~1 ~ � �zQ#bzQ#b. V� 0 d�� { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } � n 2 h zQ#b! ICON1D~2.EXE R � �zQ#bzQ#b. ��� � ��� I c o n 1 D 3 9 4 6 A 1 . e x e � R . . \ . . \ . . \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e � � L C : \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e �� � �FtVk]AMMz8SvzUNO`B%{>EQ=o1zSsp9ZlEKlJ[EbE F t V k ] A M M z 8 S v z U N O ` B % { > E Q = o 1 z S s p 9 Z l E K l J [ E b E �� � �%SystemRoot%\Installer\{A43A9851-8770-4135-B469-EA77C02E38FF}\Icon1D3946A1.exe % S y s t e m R o o t % \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e
emmm that's werid. I think this will be stored as log, so would you please share the log with me so that I can check whether it is problem when loading the lnkprogram?
Logfile reports the following, no mentioning of Presentation. By the way: The application was found with no problem in the previous release!
2021-02-15 18:01:03.6254|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6318|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories\Windows Media Player.lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:03.6318|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6318|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6495|ERROR||
Exception full name: System.IO.FileNotFoundException
Error status: KNOWN
Class name: UWP
Calling method: LogoPathFromUri
Program path: C:\Windows\SystemApps\Microsoft.Windows.SecHealthUI_cw5n1h2txyewy
InnerException number: 1
Exception message: Unable to find the specified file.
Exception error type: HResult -2147024894
Exception thrown in called method: Not available
Possible interpretation of the error: Microsoft.Windows.SecHealthUI_cw5n1h2txyewy!SecHealthUI can't find logo uri for Assets\Square44x44Logo.png in package location: C:\Windows\SystemApps\Microsoft.Windows.SecHealthUI_cw5n1h2txyewy
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:03.6495|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6495|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6662|ERROR||
Exception full name: System.IO.FileNotFoundException
Error status: KNOWN
Class name: UWP
Calling method: LogoPathFromUri
Program path: C:\Program Files\WindowsApps\word.office.com-CECA1A7F_1.0.0.0_neutral__jc2kecmnkxwqc
InnerException number: 1
Exception message: Unable to find the specified file.
Exception error type: HResult -2147024894
Exception thrown in called method: Not available
Possible interpretation of the error: word.office.com-CECA1A7F_jc2kecmnkxwqc!App can't find logo uri for Images\Square44x44Logo.png in package location: C:\Program Files\WindowsApps\word.office.com-CECA1A7F_1.0.0.0_neutral__jc2kecmnkxwqc
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:03.6662|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6772|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:03.6772|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\ODBC Data Sources (32-bit).lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:03.6772|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:04.5258|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:04.5258|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories\Windows Media Player.lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:04.5379|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:04.5379|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 18:01:04.5568|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\ODBC Data Sources (32-bit).lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 18:01:04.5568|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
ok, so it is not because of lnkprogram issue, check out this build. https://ci.appveyor.com/api/buildjobs/6sx2mp18s8lwkca7/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.1.exe
now the help gets shown, but the main program not, but one step further haha
2021-02-15 19:33:42.6716|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:42.6793|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories\Windows Media Player.lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:42.6793|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:42.7003|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:42.7003|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\ODBC Data Sources (32-bit).lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:42.7141|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:42.7346|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:42.7410|ERROR||
Exception full name: System.IO.FileNotFoundException
Error status: KNOWN
Class name: UWP
Calling method: LogoPathFromUri
Program path: C:\Windows\SystemApps\Microsoft.Windows.SecHealthUI_cw5n1h2txyewy
InnerException number: 1
Exception message: Unable to find the specified file.
Exception error type: HResult -2147024894
Exception thrown in called method: Not available
Possible interpretation of the error: Microsoft.Windows.SecHealthUI_cw5n1h2txyewy!SecHealthUI can't find logo uri for Assets\Square44x44Logo.png in package location: C:\Windows\SystemApps\Microsoft.Windows.SecHealthUI_cw5n1h2txyewy
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:42.7410|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.4219|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.4290|ERROR||
Exception full name: System.IO.FileNotFoundException
Error status: KNOWN
Class name: UWP
Calling method: LogoPathFromUri
Program path: C:\Program Files\WindowsApps\word.office.com-CECA1A7F_1.0.0.0_neutral__jc2kecmnkxwqc
InnerException number: 1
Exception message: Unable to find the specified file.
Exception error type: HResult -2147024894
Exception thrown in called method: Not available
Possible interpretation of the error: word.office.com-CECA1A7F_jc2kecmnkxwqc!App can't find logo uri for Images\Square44x44Logo.png in package location: C:\Program Files\WindowsApps\word.office.com-CECA1A7F_1.0.0.0_neutral__jc2kecmnkxwqc
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:43.4290|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.6611|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.6675|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessories\Windows Media Player.lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:43.6675|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.6866|ERROR||------------- BEGIN Flow.Launcher.Plugin.Program exception -------------
2021-02-15 19:33:43.6866|ERROR||
Exception full name: System.Runtime.InteropServices.COMException
Error status: KNOWN
Class name: Win32
Calling method: LnkProgram
Program path: C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Administrative Tools\ODBC Data Sources (32-bit).lnk
InnerException number: 1
Exception message: Error HRESULT E_FAIL has been returned from a call to a COM component.
Exception error type: HResult -2147467259
Exception thrown in called method: Void GetDescription(System.Text.StringBuilder, Int32)
Possible interpretation of the error: Error caused likely due to trying to get the description of the program
Possible resolution: Can be ignored and Flow Launcher should still continue, however the program may not be loaded
2021-02-15 19:33:43.6987|ERROR||------------- END Flow.Launcher.Plugin.Program exception -------------
The logs is fine. These errors are normal. Would you please show me with the target program of these lnk?
it's NeuroBS Presentation player, you can download the installer here:
@skjerns I found the issue. Both of them resolve to the same path, so that only one of them are kept.
my antivirus program actually block it, suggesting that it contains trojan.....Not sure why.
I'm pretty sure there is no virus inside, it's a product that costs several thousand dollars. HEUR
means the heuristic rules determined that it was maybe containing malicious code, this could be due to anything, e.g. code snippets that makes the taskbar dissappear, etc. I had it often when developing apps using VB6, so often that I had to disable heuristics all together. Usually the heuristics have a lot of false positives compared to hash methods
feel free to upload the file to https://www.virustotal.com/gui/ and check with other virus detection enginges.
Oh haha understand. No problem for that. I am not sure how we should resolve this issue. Maybe we should make the list we registered manually outside the one that will be checked for duplicate, so at least you can manually add that to index. Let me take a try, and I will reach out back.
@skjerns https://ci.appveyor.com/api/buildjobs/60w6675kijv0378n/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.1.exe check out this build, and manually add the folder containing the Presentation program to the program source. This may create an extra duplicate that kept by autoindexing, maybe I can add a distinct to that to check whether it works.
@skjerns sorry for re-asking to try so frequently XD, I just implement the thing I describe on the last comment. It works, and only one result will be stored.
Here is the artifact @skjerns https://ci.appveyor.com/api/buildjobs/mi155t89nran6cwn/artifacts/Output%2FPackages%2FFlow-Launcher-v1.7.1.exe
@skjerns I found the issue. Both of them resolve to the same path, so that only one of them are kept.
Could the documentation use an argument that's passed through as a parameter to the executable to bring up help? Surely both entries can't be running the program
@skjerns I found the issue. Both of them resolve to the same path, so that only one of them are kept.
Could the documentation use an argument that's passed through as a parameter to the executable to bring up help? Surely both entries can't be running the program
I don't know how this programs works. but seems not quite possible
If you look at the property of the shortcut, does it show any arguments being passed through to the executable?
No, I don't understand how this works.
I think this is a different style lnk created by windows installer, might be connected to App Store stuff.
see also the source code of the lnk, maybe that helps?
L ��� � F�P � � ��� �P�O� �:i���� +00�� /C:\ V 1 mQ
L� Windows @ � ヌOwHzQ b. �� � �
�W i n d o w s � \ 1 zQ#b� Installer D � ヌO�IzQ#b. �� � ��� I n s t a l l e r � � 1 zQ#b� {A43A9~1 ~ � �zQ#bzQ#b. V� 0 d�� { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } � n 2 h zQ#b! ICON1D~2.EXE R � �zQ#bzQ#b. ��� � ��� I c o n 1 D 3 9 4 6 A 1 . e x e � R . . \ . . \ . . \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e � � L C : \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e �� � �FtVk]AMMz8SvzUNO`B%{>EQ=o1zSsp9ZlEKlJ[EbE F t V k ] A M M z 8 S v z U N O ` B % { > E Q = o 1 z S s p 9 Z l E K l J [ E b E �� � �%SystemRoot%\Installer\{A43A9851-8770-4135-B469-EA77C02E38FF}\Icon1D3946A1.exe % S y s t e m R o o t % \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e
the link target is this
I think this is a different style lnk created by windows installer, might be connected to App Store stuff.
see also the source code of the lnk, maybe that helps?
L ��� � F�P � � ��� �P�O� �:i���� +00�� /C:\ V 1 mQ L� Windows @ � ヌOwHzQ b. �� � � �W i n d o w s � \ 1 zQ#b� Installer D � ヌO�IzQ#b. �� � ��� I n s t a l l e r � � 1 zQ#b� {A43A9~1 ~ � �zQ#bzQ#b. V� 0 d�� { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } � n 2 h zQ#b! ICON1D~2.EXE R � �zQ#bzQ#b. ��� � ��� I c o n 1 D 3 9 4 6 A 1 . e x e � R . . \ . . \ . . \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e � � L C : \ W i n d o w s \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e �� � �FtVk]AMMz8SvzUNO`B%{>EQ=o1zSsp9ZlEKlJ[EbE F t V k ] A M M z 8 S v z U N O ` B % { > E Q = o 1 z S s p 9 Z l E K l J [ E b E �� � �%SystemRoot%\Installer\{A43A9851-8770-4135-B469-EA77C02E38FF}\Icon1D3946A1.exe % S y s t e m R o o t % \ I n s t a l l e r \ { A 4 3 A 9 8 5 1 - 8 7 7 0 - 4 1 3 5 - B 4 6 9 - E A 7 7 C 0 2 E 3 8 F F } \ I c o n 1 D 3 9 4 6 A 1 . e x e
the link target is this
Yeah the issue is that all the link points to the same program, so the hasher will view them as one. Therefore, I think we can only do that by manually adding it to index as I suggest before.
however, how does windows figure out which program to run? It can't be entirely the same program
also the icon is different, so that might be used as a distinguishing feature?
It happens quite often that Flow shows me duplicate applications. Would it be possible to check whether something is already in the index and keep the program index cleaner? This could also be done e.g. by checking the link target instead of the link location (including args of course).
Related: #303