search

Flow-Launcher / Flow.Launcher

:mag: Quick file search & app launcher for Windows with community-made plugins
https://flowlauncher.com
MIT License
7.91k stars 308 forks source link

Remove other search precision levels #528

Open taooceros opened 3 years ago

taooceros commented 3 years ago

Discussed in https://github.com/Flow-Launcher/Flow.Launcher/discussions/517

Originally posted by **jjw24** April 25, 2020 Unless I am wrong, other search precision levels- None, Low are not used much by user base. This assumption is that precision level saving is broken and no one has put forward an issue about it in the JJW24 fork. ![image](https://user-images.githubusercontent.com/26427004/80270083-7fa8c600-86f8-11ea-8a2f-d15252195206.png) Removing others can help simplify logic and focus on fine tuning the search for one level going forward.
skjerns commented 3 years ago

Wrong! I use None, as otherwise some of my results are not being shown properly, e.g. programms using Umlauts or searching for special chars. E.g. when I want to open Notepad++ I type ++, but this only shows the app when setting precision to "None" or low

jjw24 commented 3 years ago

Can you give me some examples of the searches you are not getting with regular

Also what version of flow you are currently using

skjerns commented 3 years ago

I'm using 1.8.1, I just checked the forum as each version update resets my settings for the precision value.

I can see if I can remember more cases, but for that I need to turn it off and wait a few days. I just remember it being totally off on some queries and giving strange results last year, so I switched to "None". But might be fixed by now (except for the ++ case)

taooceros commented 3 years ago

Probably the storage of SearchPrecision setting contains an issue. Will take a look on that soon.

pc223 commented 3 years ago

Yeah I never use this feature, I always use the default. We should strive for a good default first and options later.

If User fails to find a item with a reasonable query, it should be consider bug.

jjw24 commented 3 years ago

... We should strive for a good default first and options later.

If User fails to find a item with a reasonable query, it should be consider bug.

agree, absolutely.

jjw24 commented 3 years ago

... E.g. when I want to open Notepad++ I type ++, but this only shows the app when setting precision to "None" or low

hmm mine comes up with notepad++ via querying '++'

image

But no, a fresh install will not have this come up. So it's the frequency of use that helped boost my everyday Flow to show with the '++' query.

skjerns commented 3 years ago

I agree!

my problem is, that ++ doesn't ever show up Notepad if setting to regular, so I can't really increase the frequency and "train" it. Strangely enough, the c++ compiler shows up! I have the exact same problem on different machines, so it's not just a local problem

pc223 commented 3 years ago

my problem is, that ++ doesn't ever show up Notepad if setting to regular

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

jjw24 commented 3 years ago

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

On fresh install, if you query 'notepad++' it will show somewhere on the list for sure, but you will never get it with '++' query, and consequently you cant as @skjerns mentions, train it with frequency to show up higher when query '++'. Our search algorithm never designed to bring up results on two characters on regular precision setting.

pc223 commented 3 years ago

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

On fresh install, if you query 'notepad++' it will show somewhere on the list for sure, but you will never get it with '++' query, and consequently you cant as @skjerns mentions, train it with frequency to show up higher when query '++'

No, I tried with ++ not notepad++ 😄 But i use notepad++ portable so maybe different there.

skjerns commented 3 years ago

Yes, I'm using the regularly installed version v7.9.5 64bit. Updated to Flow 1.8.2, problem still persists :-/

taooceros commented 3 years ago

I don't think training it helps, because the score bump is done after the result filtering.

jjw24 commented 3 years ago

if '++' brings up notepad++, then training would help bump it up, unless i am not remembering the design right?

taooceros commented 3 years ago

Yeah, but @skjerns cannot find notepad++ with ++. We can optimize it by let special character bumps score for acronym search, but not include it in score panelty.

jjw24 commented 3 years ago

yeah think if it's purely special symbol characters or numerals only in the query, we can bump for acronym and not include in score penalty.

pc223 commented 3 years ago

Agreed, ++ for notepad++ is a reasonable query, I think we should support this use case by default 👍

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh

onesounds commented 3 months ago

Can't we just get rid of this? I've never felt like this function works properly.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh