FlowCrypt / flowcrypt-android

FlowCrypt Android App
https://flowcrypt.com
Other
90 stars 11 forks source link

[Feature suggestion] Implement Folder Icons in Side Menu to Match iOS App UI #2446

Closed ioanmo226 closed 1 year ago

ioanmo226 commented 1 year ago

iOS app has neat folder icons in the side menu. It would make the UI look more polished and consistent across platforms.

image

@DenBond7 What's your thoughts?

DenBond7 commented 1 year ago

Looks great! I will add icons in the next release.

DenBond7 commented 1 year ago

@ioanmo226 or @sosnovsky Could you share icons or show me where they are located?

ioanmo226 commented 1 year ago

iOS app uses SFSymbols image

DenBond7 commented 1 year ago

Is it possible to have SVG(preferable) or PNG?

ioanmo226 commented 1 year ago

Ok, let me export to SVG and share it here

ioanmo226 commented 1 year ago

This envelope(For inbox folder) is exported from SF symbols. Can you use it or you need in another format?

envelope

ioanmo226 commented 1 year ago

Just got those icons from https://github.com/brendanballon/sfsymbols-svg Here's mapping for each icon for folders

var mailFolderIcon: String {
  switch self {
  case "INBOX":
      return "envelope"
  case "CHAT":
      return "message"
  case "SENT":
      return "paperplane"
  case "IMPORTANT", "":
      return "tag"
  case "TRASH":
      return "trash"
  case "DRAFT":
      return "square.and.pencil"
  case "SPAM":
      return "exclamationmark.shield"
  case "STARRED":
      return "star"
  case "UNREAD":
      return "envelope.badge"
  default:
      return "tag.fill"
  }
}

Archive.zip

DenBond7 commented 1 year ago

Just got those icons from https://github.com/brendanballon/sfsymbols-svg

Perfect! Thank you!

sosnovsky commented 1 year ago

Maybe Android has some built-in icons set? So we can use it, instead of icons exported from iOS

DenBond7 commented 1 year ago

I'm thinking about that. And maybe due to different licenses, it will be better to use Android icons. I will try to find similar icons in the Android set.

ref https://fonts.google.com/icons

sosnovsky commented 1 year ago

I think Material Icons are the most common for Android projects - https://developer.android.com/reference/kotlin/androidx/compose/material/icons/package-summary

DenBond7 commented 1 year ago

yup. you are right

DenBond7 commented 1 year ago

image image

sosnovsky commented 1 year ago

Looks nice 👍