FlowCrypt / flowcrypt-android

FlowCrypt Android App
https://flowcrypt.com
Other
91 stars 11 forks source link

save private key as a file: open device folder #294

Closed tomholub closed 1 year ago

DenBond7 commented 5 years ago

@tomholub Please describe details or move it to another milestone

tomholub commented 5 years ago

When I want to save a private key on a device, it will not choose any folder, so the save button is grayed out and I cannot save it until I choose a folder. It confuses me every time:

screenshot_20181017-013043

tomholub commented 5 years ago

Is there a way to pre-define a folder to open? Maybe just root folder would do:

screenshot_20181017-013125

DenBond7 commented 5 years ago

@tomholub

Is there a way to pre-define a folder to open?

Unfortunately, No there is not. Android doesn't have any settings for that.

For creating a key we are using Storage Access Framework (SAF). The Android app which is handling ACTION_CREATE_DOCUMENT (this app is a part of the Android system) can be different from version to version. For example on my Xiami Mi A1 (Android 8.0) the default folder is Downloads

tomholub commented 5 years ago

I tested a few other apps saving files, and they all seem to be using Download Manager. If we did that, it would presumably be easier, but the file would have to always end up in Downloads. Is that correct?

tomholub commented 5 years ago

For now moving it out

DenBond7 commented 5 years ago

If we did that, it would presumably be easier, but the file would have to always end up in Downloads. Is that correct?

Yes, it is. DownloadManager just downloads a file from the given Uri.

Storage Access Framework (SAF) is a more powerfull solution because it helps to work with different document providers. A user can easy save his private key to Google Drive, Dropbox and to other different places using a couple steps.

I think we can add the third option to the backup options. We can use both methods. Or we can use DownloadManager as a simpler solution.

DenBond7 commented 5 years ago

Yes, it is. DownloadManager just downloads a file from the given Uri.

Sorry, I was wrong. DownloadManager can only download HTTP/HTTPS URIs. So we can't use it for our purposes. But we can create a similar solution.

tomholub commented 5 years ago

For now, let's leave it as is. We will revisit it when users start complaining about it.

DenBond7 commented 1 year ago

deprecated