search

FlowCrypt / flowcrypt-android

FlowCrypt Android App
https://flowcrypt.com
Other
90 stars 11 forks source link

consider LiquidCore instead of Node #811

Closed tomholub closed 3 years ago

tomholub commented 4 years ago

I will experiment with using LiquidCore instead of full-fledged Nodejs instance.

On iOS we use something very similar to that, and it works well + is very light weight.

https://github.com/LiquidPlayer/LiquidCore/wiki/LiquidCore-as-a-Raw-JavaScript-engine-for-Android-(v.-0.7.0-)

Another advantage will be that we would not need to create RSA certs when app starts, and we would not need to communicate over https and so on. Quite similar to what we have done before with J2V8, but hopefully it will work better.

This will almost certainly resolve #753

tomholub commented 4 years ago

Also it will reduce app footprint, no longer need to include node binaries for all platforms.

DenBond7 commented 4 years ago

@tomholub Very interesting... need to investigate that. Basically, the current realization works much better than j2v8. But of course, we have many places which we can improve.

tomholub commented 4 years ago

They designed it to be very similar to JavaScriptCore which we use on iOS:

https://github.com/FlowCrypt/flowcrypt-ios/blob/master/FlowCrypt/Core/Core.swift#L84

tomholub commented 3 years ago

superseded by #976