error rendering

[tomholub]

right now I render all errors with alert() for simplicity. Better way is to have a set space in each template where errors will go, if any.

Errors can happen:

• during setup and in settings
• when composing a message
• when replying to a message
• general errors in gmail window

For composing/replying messages in gmail window, we can keep them within the iframe, or outside the iframe as well. I like when errors show rather nearer to the action buttons that caused them, so within iframes would probably make more sense.

[mondo989]

I agree clicking an alert is a bit of a pain. Also that it's a good idea to keep the error message easily visible to the action button

In settings, what if we call in divs and populate the error message?

Maybe we can reuse it in different places?

I pushed some code that has the message and it's transition, right now on line 61 #error_text_container is display: none; If you display block it will appear like below.

[tomholub]

I like it, for settings, this will work nicely :)

[mondo989]

When composing a message:

[mondo989]

Replying to a message

[mondo989]

Both messages use a little animation to fade up coming from the button. At the moment they are just active by default.

Let me know if you have any feedback on these...

Out of curiousity, what might be an example of a general error in gmail window? Either the wording or like a use case?

[tomholub]

General in window - maybe like "your cryptup key needs a backup" or something. But I might just emulate gmail notifications (the yellow ones) like I do now.

I'll hide the error messages until I can connect them. I'd also experiment with more colors, like maybe borderless and white background

[tomholub]

this is especially important for issues like #233

[mondo989]

@tomholub - on a previous project, we used SweetAlert, for error handling.

Check it out and let me know if you have any thoughts on it. https://t4t5.github.io/sweetalert/

[tomholub]

Oh that's a great start. I'll replace all alerts asap!!! :)

-- Tom James Holub http://holub.me/

On Sun, Feb 12, 2017 at 11:47 AM, Armando notifications@github.com wrote:

@tomholub https://github.com/tomholub - on a previous project, we used SweetAlert, for error handling.

Check it out and let me know if you have any thoughts on it. https://t4t5.github.io/sweetalert/

[image: screen shot 2017-02-12 at 1 45 51 pm] https://cloud.githubusercontent.com/assets/3431871/22865420/9acccf34-f129-11e6-926c-166ca6a234ef.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomholub/cryptup-chrome/issues/115#issuecomment-279243059, or mute the thread https://github.com/notifications/unsubscribe-auth/AGA8kSt21VI3RTspZoSQMolBXRiHfb4-ks5rb2G5gaJpZM4ICyiE .

[mondo989]

Yeee! Awesome.

[tomholub]

There's a maintained version of it that I'll use https://github.com/limonte/sweetalert2 Looks really nice.

[mondo989]

👍 👍 👍