search

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 48 forks source link

Porting FlowCrypt to Safari using Xcode's extension porting utility #3218

Open seisvelas opened 3 years ago

seisvelas commented 3 years ago

I’m wondering if with the release of the Safari Extension porting capability in Xcode (https://developer.apple.com/documentation/safariservices/safari_web_extensions/converting_a_web_extension_for_safari), if there are any plans to bring support for FlowCrypt to Safari.

I did try to port the extension myself, was able to get it installed and configure my key, and even see the Secure Compose button on the Gmail page, but ultimately decrypting and composing did not work properly. If I can be of any help with this, please let me know. Thank you!

ref: https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgxwKjnVFjfFhVRbrCjsWnTncPHpg

I haven't used this tool, but it sounds like it got pretty close to porting FlowCrypt on its own. I don't know if this is something we are interested in but it certainly piqued my curiosity.

tomholub commented 3 years ago

My email followup

does the converter show a diff of code that was actually altered by it? That would be very helpful.

Because while this may work as a short-term solution, ultimately the converter works on the produced javascript, but we develop our extension in TypeScript, and so we'll have to find a way to update the source TypeScript instead, which will involve manual effort.

Also, when you tested the decrypt or compose flows in Safari, and it didn't work - please check for any errors in the browser developer console, and also in the console of the background page. That could give us pointers on what to fix further.

tomholub commented 2 years ago

This is actionable for later - it would be nice to try and see if the extension can be compatible with Safari.

martgil commented 2 years ago

some users find it helpful to have FlowCrypt for Safari:

reference: https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgzGpGnFnvHppPpFVkxKdqNCPGHJK

martgil commented 2 years ago

I checked out if I can convert our extension to safari but it doesn't work for me - not sure if the error is related to apple silicon compatibility because even a simple extension can't be converted. I'm following the instructions at https://www.vshsolutions.com/blogs/convert-chrome-extension-to-safari-web-extension/.