FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox
https://flowcrypt.com
Other
372 stars 46 forks source link

The font used in the Gmail signature does not apply when rendered in the FlowCrypt browser extension #5362

Open martgil opened 1 year ago

martgil commented 1 year ago

Description: The font used in the Gmail signature does not apply when rendered in the FlowCrypt browser extension. Users are hoping to see the same font applied in their Gmail signature.

In my testing, I've set the email signature's font to Fixed Width and the font wasn't applied in the email rendered by the FlowCrypt extension.

image image

email signature rendered by Gmail: image

email signature rendered by FlowCrypt browser extension: image

Reference: https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgzGtwWJwMTRbKBJJhcddPbZvWsNz

sosnovsky commented 1 year ago

For now FlowCrypt supports only plain text messages, without custom fonts, (experimental support for rich text is currently available on firefox, but I think it supports only text styling, but not custom fonts) so it's not possible to apply custom fonts to signatures.

We'll come back to this issue when extension will have full support for text styling and custom fonts.

martgil commented 1 year ago

Thank you @sosnovsky. I also tried enabling the rich-text editor mode but that wouldn't help for formatting the email signature the way it should be automatically without having to format it manually during encrypted message composition.

sosnovsky commented 1 year ago

I re-checked and it seems we don't apply any styling from signature, even if it's just a bold or italic text - https://github.com/FlowCrypt/flowcrypt-browser/blob/57321dd45312184ccaba199d642e2486c268e1fb/extension/chrome/elements/compose-modules/compose-footer-module.ts#L34

So in this issue we can try to apply signature styling if rich-text mode is enabled, I'll plan it to the next milestone. Then also need to check how this styled signatures are rendered in mobile apps.

martgil commented 1 year ago

I understood. Thanks.