#5389 Upgrade to TypeScript 5.4 - Githubissues

FlowCrypt / flowcrypt-browser

FlowCrypt Browser extension for Chrome and Firefox

https://flowcrypt.com

Other

375 stars 46 forks source link

#5389 Upgrade to TypeScript 5.4 #5634

Closed sosnovsky closed 6 months ago

sosnovsky commented 6 months ago

This PR updates declarations of static methods to fix build with TS 5.4

// before
public static processNewMsg = async (view: ComposeView, newMsgData: NewMsgData): Promise<MultipleMessages> => { ...

// after 
public static async processNewMsg(view: ComposeView, newMsgData: NewMsgData): Promise<MultipleMessages> { ...

close #5389

Tests (delete all except exactly one):

Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

[x] addresses the issue it closes (if any)
[x] code is readable and understandable
[x] is accompanied with tests, or tests are not needed
[x] is free of vulnerabilities
[x] is documented clearly and usefully, or doesn't need documentation